-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallets] Sergei / wall 2103 / Autoscroll onboarding desktop #10807
Merged
mahdiyeh-deriv
merged 48 commits into
deriv-com:master
from
sergei-deriv:sergei/wall-2103/autoscroll-onboarding-desktop
Nov 9, 2023
Merged
[Wallets] Sergei / wall 2103 / Autoscroll onboarding desktop #10807
mahdiyeh-deriv
merged 48 commits into
deriv-com:master
from
sergei-deriv:sergei/wall-2103/autoscroll-onboarding-desktop
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-onboarding-steps
… sergei/wall-2128/add-onboarding-steps
…implement-simple-onboarding-step
… sergei/wall-2128/add-onboarding-steps
… sergei/wall-2128/add-onboarding-steps
…add-onboarding-steps
…add-onboarding-steps
…set-onboarding-start-in-localstorage
…add-onboarding-steps
…-2103/autoscroll-onboarding-desktop
…into sergei/wall-2103/autoscroll-onboarding-desktop
…autoscroll-onboarding-desktop
wojciech-deriv
previously approved these changes
Nov 2, 2023
mahdiyeh-deriv
previously approved these changes
Nov 3, 2023
…autoscroll-onboarding-desktop
sergei-deriv
dismissed stale reviews from mahdiyeh-deriv and wojciech-deriv
via
November 8, 2023 13:02
dba7836
sergei-deriv
requested review from
nijil-deriv and
amina-deriv
as code owners
November 8, 2023 13:02
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🚀 Smoke test run (1) passed successfully! |
🚀 Smoke test run (2) passed successfully! |
farhan-nurzi-deriv
approved these changes
Nov 9, 2023
mahdiyeh-deriv
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR extends these 2 PRs: 1st: onboarding steps, and 2nd: start onboarding by localStorage
Switch to real fiat wallet (if exists) and start onboarding
Add
dtrade_loginid
touseWalletAccountsList
hookVideo:
Screen.Recording.2023-10-19.at.17.10.00.mov