Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Lubega / WALL-2279 / Fix UI inconsistencies for withdrawal verification pages #10952

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Fix the design inconsistencies of the withdrawal verification pages for desktop and responsive
  • Modify WalletsActionScreen to accept different format of actionText and icon as optional
  • Convert pages to use wallet components and remove unused css properties
  • Ensure that the design of the fiat deposit page is correct and consistent

Source: https://docs.google.com/document/d/12F8UftGIVXvYEY73saAexw7oRWVfR6yd7IJdYX24L4E/edit

Screenshots:

image

image

image

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 26, 2023 9:30am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10952](https://github.com/binary-com/deriv-app/pull/10952)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-2279-fix-ui-inconsi-a37c32.binary.sx?qa_server=red.derivws.com&app_id=32220
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-2279-fix-ui-inconsi-a37c32.binary.sx
- **App ID**: `32220`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-2279-fix-ui-inconsi-a37c32.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 26.731% (+0.004%) from 26.727% when pulling e1920d9 on lubega-deriv:WALL-2279/fix-ui-inconsistencies-fiat into 9ff6169 on binary-com:master.

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nijil-deriv nijil-deriv merged commit 045fc7e into deriv-com:master Oct 26, 2023
6 checks passed

&__description {
display: flex;
flex-direction: column;
gap: 1.6rem;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 great to see such big cleanups :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants