Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maryia/BOT-905/Quick Strategy minor bug fixes and improvements #11116

Merged
merged 25 commits into from
Nov 23, 2023
Merged

Maryia/BOT-905/Quick Strategy minor bug fixes and improvements #11116

merged 25 commits into from
Nov 23, 2023

Conversation

maryia-matskevich-deriv
Copy link
Contributor

@maryia-matskevich-deriv maryia-matskevich-deriv commented Nov 1, 2023 •
edited
Loading

Changes:

Quick Strategy minor bug fixes and improvements
1 fix: Unable to see typed texts on the Quick Strategy Field
2 fix: [Mobile] Remove the text cursor on mobile as we have disabled the keyboard
3 fix: Quick strategy: Duration field validation error is not displayed when switching the duration type
4 fix: appearance of the caret in symbol dropdown upon typing text
*test coverage has been added due to a change in logic

Screenshots:

Screen.Recording.2023-11-01.at.19.35.15.mov
Screenshot 2023-11-16 at 19 43 55

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 21, 2023 11:56am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/11116](https://github.com/binary-com/deriv-app/pull/11116)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-bot-905.binary.sx?qa_server=red.derivws.com&app_id=24099
    - **Original**: https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-bot-905.binary.sx
- **App ID**: `24099`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-bot-905.binary.sx/

@maryia-matskevich-deriv maryia-matskevich-deriv marked this pull request as draft November 2, 2023 10:47
vinu-deriv
vinu-deriv previously approved these changes Nov 20, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@vinu-deriv vinu-deriv merged commit ba632d7 into deriv-com:master Nov 23, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeep-deriv sandeep-deriv sandeep-deriv left review comments

@shafin-deriv shafin-deriv shafin-deriv approved these changes

@vinu-deriv vinu-deriv vinu-deriv approved these changes

@rupato-deriv rupato-deriv rupato-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

@prince-deriv prince-deriv Awaiting requested review from prince-deriv

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

Assignees
No one assigned
Labels
Bot Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maryia-matskevich-deriv @shafin-deriv @coveralls @sandeep-deriv @rupato-deriv @vinu-deriv