Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] shontzu/CFDS-1435/use-landing-company-hooks-for-cTrader-and-DxTrade #11608

Conversation

shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Nov 21, 2023

create a hook using landing_company endpoint to get available cTrader and dxTrade accounts

current behaviour

  • using flags like CFDs_restricted_countries and financial_restricted_countries to filter for available cTrader and dxTrade accounts:

expected behaviour

  • using the landing_company hook to check if ctrader and dxtrade are allowed in client's country of residence
  • in the case of dxtrade, when it is available, dxtrade_all_company will be in the response, else, it is not in the response
  • in the case of ctrader, when it is available, ctrader will be in the response and the jurisdiction will be svg. Else, ctrader will be in the response but the jurisdiction will be empty string (' ') or undefined

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 22, 2023 7:12am

@shontzu-deriv shontzu-deriv changed the title refactor: hook to check if ctrader and dxtrade is allowed in current … [Refactoring] shontzu/CFDS-1435/use-landing-company-hooks-for-cTrader-and-DxTrade Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11608](https://github.com/binary-com/deriv-app/pull/11608)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-1435use-la-1bac54.binary.sx?qa_server=red.derivws.com&app_id=32805
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-1435use-la-1bac54.binary.sx
- **App ID**: `32805`

@coveralls
Copy link

coveralls commented Nov 21, 2023

Coverage Status

coverage: 28.12% (+0.4%) from 27.738%
when pulling 604d599 on shontzu-deriv:shontzu/CFDS-1435/use-landing-company-hooks-for-cTrader-and-DxTrade
into 8c2914b on binary-com:master.

Copy link
Contributor

github-actions bot commented Nov 21, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-1435use-la-1bac54.binary.sx/

Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com>
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@hirad-deriv hirad-deriv merged commit 2d268d1 into deriv-com:master Nov 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants