Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Aizad/ChangePasswordModalImprovements #11708

Conversation

aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Nov 23, 2023

Changes:

  • added platform prop inside of ChangePassword modal so it can be used for every platform i.e: Deriv MT5, Deriv X, ...

Screenshots:

Screen.Recording.2023-11-23.at.4.15.20.PM.mov

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 23, 2023 8:43am

Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Nov 23, 2023

Coverage Status

coverage: 28.191% (+0.005%) from 28.186%
when pulling c885b2f on aizad-deriv:aizad/improvement_for_change_password
into d6e8292 on binary-com:master.

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11708](https://github.com/binary-com/deriv-app/pull/11708)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-improvementforchang-457b97.binary.sx?qa_server=red.derivws.com&app_id=32678
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-improvementforchang-457b97.binary.sx
- **App ID**: `32678`

Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-improvementforchang-457b97.binary.sx/

Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yashim-deriv yashim-deriv merged commit 1557c8e into deriv-com:master Nov 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants