Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFDs] Hirad/ Added the icon functionality to cTrader #11865

Conversation

hirad-deriv
Copy link
Contributor

Changes:

Open the cTrader landing page when clicking the cTrader icon in Trader's hub

Screenshots:

Please provide some screenshots of the change.

image image

Click Up card:

https://app.clickup.com/t/20696747/CFDS-1372

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 6, 2023 3:23am

@coveralls
Copy link

coveralls commented Nov 29, 2023

Coverage Status

coverage: 29.707% (-0.001%) from 29.708%
when pulling 3f8e393 on hirad-deriv:Hirad/CFDs-1372/cTrader-icon-functionality
into 039a700 on binary-com:master.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11865](https://github.com/binary-com/deriv-app/pull/11865)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hirad-deriv-hirad-cfds-1372ctrader-ic-d5f235.binary.sx?qa_server=red.derivws.com&app_id=23887
    - **Original**: https://deriv-app-git-fork-hirad-deriv-hirad-cfds-1372ctrader-ic-d5f235.binary.sx
- **App ID**: `23887`

Copy link
Contributor

github-actions bot commented Nov 29, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 85
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hirad-deriv-hirad-cfds-1372ctrader-ic-d5f235.binary.sx/

hamza-deriv
hamza-deriv previously approved these changes Nov 29, 2023
Copy link
Contributor

@shontzu-deriv shontzu-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Dec 4, 2023
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

github-actions bot commented Dec 6, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Dec 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Dec 6, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@hirad-deriv hirad-deriv merged commit abe9020 into deriv-com:master Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants