Likhith/wall 1714/enhance error message handling for poi #11912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d/wall-400/IDV-error-message-handled
…com:likhith-deriv/deriv-app; branch 'master' of github.com:binary-com/deriv-app into combined/wall-400/IDV-error-message-handled
…com:likhith-deriv/deriv-app; branch 'master' of github.com:binary-com/deriv-app into combined/wall-400/IDV-error-message-handled
…d/wall-400/IDV-error-message-handled
…d/wall-400/IDV-error-message-handled
…d/wall-400/IDV-error-message-handled
…com:likhith-deriv/deriv-app into combined/wall-400/IDV-error-message-handled
…d/wall-400/IDV-error-message-handled
likhith-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
likhith-deriv
requested review from
ali-hosseini-deriv,
matin-deriv,
maryia-deriv and
amina-deriv
as code owners
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-wall-1714enhanc-549bf9.binary.sx/ |
amina-deriv
reviewed
Nov 30, 2023
…/enhance-error-message-handling-for-poi
likhith-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
likhith-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
…/enhance-error-message-handling-for-poi
likhith-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
likhith-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
Kudos, SonarCloud Quality Gate passed!
|
yauheni-deriv
approved these changes
Nov 30, 2023
amina-deriv
approved these changes
Nov 30, 2023
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
jim-deriv
pushed a commit
that referenced
this pull request
Dec 1, 2023
* fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ⬆️ upgraded SDK and handled language change * fix: ♻️ incorporated review comments * fix: ♻️ refactored code to remove useRef * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: ♻️ incorporated hooks to handle business logic * refactor: css structure * fix: barriers test * fix: ⚰️ removed unwanted code * test: 🔥 removed mocked tokens * chore: 📝 Added documentation for UseNotificationEvent hook * fix: 💄 incorporated styling * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * fix: ♻️ incorporated review comments * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * build: 📌 updated package-lock after updating onfido-sdk-ui * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: ♻️ removed default values * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: ⚡ incorporated platform language change * fix: removed store * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * refactor: incorporated review comments * fix: 💄 updated styles * fix: 🐛 reverted code * fix: 🐛 reverted code * refactor: incorporated review comments * fix: 🐛 Onfido SDK language code conversion * fix: migrated hooks * revert: logic for generating code * chore: adding missing testcases * fix: recatored Onfido constants * fix: onfido screen css issues * fix: removed package-lock to resolve merge error * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * chore: added package-lock * Merge branch 'master' into combined/wall-400/IDV-error-message-handled * chore: Trigger Build * fix: bug: /WEBREL-1358/personal-details page and poa page css issue * fix: layout button * fix: layout button * fix: mt5 next button not getting enabled * fix: resolved issue with button * fix: resolved issue with button * fix: resolved missing dropdown * fix: removed console * fix: incorporated review comments * feat: ✨ incorporated new images and merged checkbox feature * feat: ✨ incorporated new images and merged checkbox feature * refactor: split components * fix: idv failed document type * fix: removed duplicate import * fix: incorporated error message scenario * fix: styling as per new figma * fix: styling as per new figma * fix: spacing between fields * fix: spacing between fields * fix: spacing between fields * fix: incorporated new error code and styles as per new figma * fix: incorporated new error code and styles as per new figma * feat: incorporated idv-error codes * Merge branch 'master' into likhith/kyc-195/display-idv-error-messages * fix: reverted changes * Incorporate poi context (#55) * chore: incorporate POIContext to keep track of submission * chore: reset poi context state upon route change * refactor: added reset for all path * fix: changed testcases --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> * fix: incorporated Onfido error messages * chore: removed dead code * fix: incorporated review comments * fix: incorporated review comments * fix: import paths * fix: Onfido error for failed selfie check * fix: incorporated missing status code * fix: button width * fix: Error text for Failure of IDV * fix: changed icon badge * fix: onfido check in POI * fix: failing testcase * fix: user flow for POI * fix: layout for Expired scenario in onfido * fix: styling of erro message * fix: code smells * chore: trigger rebuild * fix: issue with checkbox * fix: removed unused import * fix: added keyboard event * fix: resolved build failure * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * fix: Onfido styles * fix: resolved code-smells * fix: resolved code smells * fix: code styling * fix: review comments * Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714/enhance-error-message-handling-for-poi * Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714/enhance-error-message-handling-for-poi * Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714/enhance-error-message-handling-for-poi --------- Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Shahzaib <shahzaib@deriv.com>
jim-deriv
added a commit
that referenced
this pull request
Dec 1, 2023
)" This reverts commit fa8da5d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: