Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[dtra]/Ahmad/showing digits on the Matchers/Differs contract type on mobile screen" #12047

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Revert "[dtra]/Ahmad/showing digits on the Matchers/Differs contract type on mobile screen" #12047

merged 1 commit into from
Dec 6, 2023

Conversation

hamza-deriv
Copy link
Contributor

Reverts #12010

review-deriv
review-deriv reviewed Dec 6, 2023
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@boring-cyborg boring-cyborg bot added the Trader label Dec 6, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app 🔄 Building (Inspect) Visit Preview Dec 6, 2023 6:08am

@hamza-deriv hamza-deriv merged commit f02344c into master Dec 6, 2023
5 of 6 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

coverage: 29.82% (-0.008%) from 29.828%
when pulling d8e7d3e on revert-12010-fix_digits_on_mobile
into 28771dd on master.

hamza-deriv added a commit that referenced this pull request Dec 6, 2023
@hamza-deriv
Revert "fix: digit fix (#12010)" (#12047)
36133cb 
This reverts commit 7bc29f4.
@chrisgodfrey-deriv chrisgodfrey-deriv deleted the revert-12010-fix_digits_on_mobile branch August 16, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@review-deriv review-deriv review-deriv left review comments

@matin-deriv matin-deriv Awaiting requested review from matin-deriv

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

Assignees
No one assigned
Labels
Trader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza-deriv @coveralls @review-deriv