Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COJ] WEBREL-1757 / fix: condition to render the modal in real account creation #12215

Conversation

shahzaib-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 13, 2023 4:38am

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
6.4% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 31.37% (-0.001%) from 31.371%
when pulling 718ee8f on shahzaib-deriv:WEBREL-1757_wrong-modal-displayed-in-real-account-signup
into 9c7a251 on binary-com:master.

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12215](https://github.com/binary-com/deriv-app/pull/12215)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-webrel-1757wrong-modal-b0b551.binary.sx?qa_server=red.derivws.com&app_id=24075
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-webrel-1757wrong-modal-b0b551.binary.sx
- **App ID**: `24075`

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-webrel-1757wrong-modal-b0b551.binary.sx/

@hamza-deriv hamza-deriv merged commit b01e92e into deriv-com:master Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants