From ded334b66b5f376d8f58108a6568925b9bf68339 Mon Sep 17 00:00:00 2001 From: Taysuisin Date: Wed, 13 Dec 2023 12:02:10 +0800 Subject: [PATCH 1/2] chore: update scss to not use max height for jurisdiction modal --- packages/components/src/components/modal/modal.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/components/src/components/modal/modal.scss b/packages/components/src/components/modal/modal.scss index 5e4c3807d82e..ca5654635ee7 100644 --- a/packages/components/src/components/modal/modal.scss +++ b/packages/components/src/components/modal/modal.scss @@ -86,6 +86,10 @@ @include desktop { min-width: 440px !important; max-height: calc(100vh - #{$HEADER_HEIGHT} - #{$FOOTER_HEIGHT}) !important; + + &_jurisdiction-modal { + max-height: none !important; + } } @include mobile { max-width: calc(100vw - 3.2rem) !important; From e939f5b4679972e736e745e9ff9c80b9e7e8497a Mon Sep 17 00:00:00 2001 From: Taysuisin Date: Thu, 14 Dec 2023 12:07:51 +0800 Subject: [PATCH 2/2] chore: update scss to make jurisdiction modal scrollable when user screen size is small --- packages/cfd/src/sass/cfd.scss | 1 + packages/components/src/components/modal/modal.scss | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/cfd/src/sass/cfd.scss b/packages/cfd/src/sass/cfd.scss index 08c4e8b92ba0..309f794aa013 100644 --- a/packages/cfd/src/sass/cfd.scss +++ b/packages/cfd/src/sass/cfd.scss @@ -403,6 +403,7 @@ .dc-modal-header { border-bottom: 2px solid var(--general-section-1); } + overflow-y: auto; } .poi-poa-submitted { diff --git a/packages/components/src/components/modal/modal.scss b/packages/components/src/components/modal/modal.scss index ca5654635ee7..5e4c3807d82e 100644 --- a/packages/components/src/components/modal/modal.scss +++ b/packages/components/src/components/modal/modal.scss @@ -86,10 +86,6 @@ @include desktop { min-width: 440px !important; max-height: calc(100vh - #{$HEADER_HEIGHT} - #{$FOOTER_HEIGHT}) !important; - - &_jurisdiction-modal { - max-height: none !important; - } } @include mobile { max-width: calc(100vw - 3.2rem) !important;