Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] Hamza / TRAH-2615 /Added Carousel component #12738

Conversation

hamza-deriv
Copy link
Contributor

@hamza-deriv hamza-deriv commented Jan 4, 2024

Changes:

Please provide a summary of the change.

implement CompareAccountsCarousel inside TradersHub

Screenshots:

Please provide some screenshots of the change.

image

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 11:04am

@hamza-deriv hamza-deriv self-assigned this Jan 4, 2024
@hamza-deriv hamza-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 4, 2024
@coveralls
Copy link

coveralls commented Jan 4, 2024

Coverage Status

coverage: 34.186% (-0.005%) from 34.191%
when pulling 4feb030 on hamza-deriv:hamza/TRAH-2614/compare-accounts-carousel-component
into 7775c6a on binary-com:master.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12738](https://github.com/binary-com/deriv-app/pull/12738)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-trah-2614compare-ac-290c27.binary.sx?qa_server=red.derivws.com&app_id=32113
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-trah-2614compare-ac-290c27.binary.sx
- **App ID**: `32113`

Copy link
Contributor

github-actions bot commented Jan 4, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-trah-2614compare-ac-290c27.binary.sx/

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@hirad-deriv hirad-deriv merged commit 276ef09 into deriv-com:master Jan 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants