Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/TRAH-2684/fix: mt5 get more button not launching jurisdicton modal and cfd maltainvest #13056

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. mt5 get more button not launching jurisdicton modal
  2. cfd maltainvest is showing in non-eu section

Screenshots:

2024-01-19_15-16

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 19, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Jan 19, 2024
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 19, 2024 7:58am

Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 34.77% (-0.001%) from 34.771%
when pulling 6b0f042 on thisyahlen-deriv:thisyahlen/thisyahlen/TRAH-2684/mt5_fixes
into a2fecc3 on binary-com:master.

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13056](https://github.com/binary-com/deriv-app/pull/13056)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-thisyahle-ae3dbe.binary.sx?qa_server=red.derivws.com&app_id=24043
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-thisyahle-ae3dbe.binary.sx
- **App ID**: `24043`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 18
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-thisyahle-ae3dbe.binary.sx/

@mahdiyeh-deriv mahdiyeh-deriv merged commit 6509df7 into deriv-com:master Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants