Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] [Fix] Rostislav / WALL-3281 / Jurisdiction modal issues #13397

Conversation

rostislav-deriv
Copy link
Contributor

@rostislav-deriv rostislav-deriv commented Feb 6, 2024

Changes:

  • fix the issue described in the card within the jurisdiction modal

Screenshots:

Screen.Recording.2024-02-08.at.02.44.18.mov

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 19, 2024 1:09pm

Copy link
Contributor

github-actions bot commented Feb 6, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13397](https://github.com/binary-com/deriv-app/pull/13397)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3281ju-00ce36.binary.sx?qa_server=red.derivws.com&app_id=32205
    - **Original**: https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3281ju-00ce36.binary.sx
- **App ID**: `32205`

Copy link
Contributor

github-actions bot commented Feb 6, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3281ju-00ce36.binary.sx/

@coveralls
Copy link

coveralls commented Feb 7, 2024

Coverage Status

coverage: 36.799% (-0.01%) from 36.81%
when pulling 4873f2c on rostislav-deriv:rostislav/wall-3281/jurisdiction-modal-issues
into d3d6d98 on binary-com:master.

nijil-deriv
nijil-deriv previously approved these changes Feb 13, 2024
wojciech-deriv
wojciech-deriv previously approved these changes Feb 13, 2024
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit 4c91df3 into deriv-com:master Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants