[P2PS] / Ameerul / P2PS-2375 Remove P2P API from DTrader page #13488

ameerul-deriv · 2024-02-09T08:22:58Z

Changes:

Please provide a summary of the change.

Removed any p2p calls outside of p2p, only call them in p2p
Added logic for is_p2p_user tracking p2p_status from get_account_status
Prevent subscribing if the user is not a p2p user for p2p_advertiser_info and p2p_order_list inside of p2p
Moved useP2PCompletedOrderNotifications into app in p2p
Added new is_p2p_user return value in useGetAccountStatus hook

Screenshots:

Please provide some screenshots of the change.

remove.p2p.calls.outside.of.p2p.mov

vercel · 2024-02-09T08:23:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Feb 19, 2024 9:28am

ameerul-deriv · 2024-02-09T08:24:24Z

packages/p2p/src/pages/my-profile/my-profile.tsx

-        !general_store.poi_status &&
-        !general_store.should_show_dp2p_blocked
-    ) {
+    if (general_store.is_p2p_user === null) {


Since we no longer call the endpoint, the previous checks will forever load the page, needed to check if get_account_status returns p2p_status instead. Resolves loading issue

ameerul-deriv · 2024-02-09T08:24:33Z

packages/p2p/src/stores/general-store.js

@@ -44,6 +44,7 @@ export default class GeneralStore extends BaseStore {
    is_listed = false;
    is_loading = false;
    is_p2p_blocked_for_pa = false;
+    is_p2p_user = null;


have to add another observable for this, cause we can't use hooks inside the store 😢 but for v2 all of this will be gone 😄

ameerul-deriv · 2024-02-09T08:24:48Z

packages/p2p/src/stores/general-store.js

-                    },
-                    [this.setP2pOrderList]
+                    [this.updateAdvertiserInfo, response => sendbird_store.handleP2pAdvertiserInfo(response)],
+                    this.is_p2p_user


only calls if the user has 'active' or 'temp_ban' statuses, else no need to call to reduce load for BE

ameerul-deriv · 2024-02-09T08:24:57Z

packages/p2p/src/stores/general-store.js

-                order_list_subscription: subscribeWS(
-                    {
-                        p2p_order_list: 1,
-                        subscribe: 1,
-                        offset: 0,
-                        limit: this.list_item_limit,
-                    },
-                    [this.setP2pOrderList]


no longer need this since the useP2PCompletedOrderNotifications hook is enough

…m:niloofar-deriv/deriv-app into P2PS-2375-remove-p2p-api-calls-from-dtrader-page

github-actions · 2024-02-09T08:33:21Z

A production App ID was automatically generated for this PR. (log)

PR: [P2PS] / Ameerul / P2PS-2375 Remove P2P API from DTrader page #13488
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-ameerul-deriv-p2ps-2375-remove-p2p-ap-7ed306.binary.sx?qa_server=red.derivws.com&app_id=32933
- Original: https://deriv-app-git-fork-ameerul-deriv-p2ps-2375-remove-p2p-ap-7ed306.binary.sx
App ID: 32933

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/13488](https://github.com/binary-com/deriv-app/pull/13488)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2375-remove-p2p-ap-7ed306.binary.sx?qa_server=red.derivws.com&app_id=32933
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2375-remove-p2p-ap-7ed306.binary.sx
- **App ID**: `32933`

github-actions · 2024-02-09T08:33:41Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	28
🟧 Accessibility	89
🟢 Best practices	92
🟧 SEO	85
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-2375-remove-p2p-ap-7ed306.binary.sx/

farrah-deriv · 2024-02-13T05:59:50Z

packages/account-v2/package.json

@@ -15,7 +15,7 @@
        "@deriv/api": "^1.0.0",
        "@deriv/library": "^1.0.0",
        "@deriv/quill-design": "^1.3.2",
-        "@deriv/quill-icons": "^1.17.4",
+        "@deriv/quill-icons": "^1.17.25",


why are we updating the version here?

the PR was failing because of it :( so i had to update it here

ameerul-deriv · 2024-02-15T09:01:00Z

packages/p2p/src/pages/buy-sell/buy-sell-table.jsx

+    React.useEffect(() => {
+        if (error?.code === api_error_codes.PERMISSION_DENIED) {
+            general_store.setIsBlocked(true);
+        }
+    }, [error?.code]);
+


previously we checked p2p_advertiser_info response for Permission Denied error, but now we don't call it if the user is not a p2p user, so need this check

ameerul-deriv · 2024-02-15T09:01:51Z

packages/p2p/src/stores/general-store.js

+            if (status.includes('cashier_locked')) {
+                this.setIsBlocked(true);
+                this.hideModal();
+            } else {
+                this.setP2pPoaRequired(p2p_poa_required);
+                this.setPoaStatus(document.status);
+                this.setPoiStatus(identity.status);
+            }
+


because we don't call p2p_advertiser_info if the user is not a p2p_user, better to move it in onMount, which also fixes issue where p2p_poa_required is not set

packages/p2p/src/pages/my-profile/my-profile.tsx

sonarcloud · 2024-02-19T08:54:49Z

Quality Gate passed

Issues
6 New issues

Measures
0 Security Hotspots
No data about Coverage
6.2% Duplication on New Code

See analysis details on SonarCloud

ameerul-deriv added 2 commits February 9, 2024 13:50

fix: removed p2p calls outside of p2p

267c4fc

fix: failing build

ed6249c

boring-cyborg bot added Core P2P labels Feb 9, 2024

ameerul-deriv had a problem deploying to Preview February 9, 2024 08:24 — with GitHub Actions Failure

ameerul-deriv temporarily deployed to Preview February 9, 2024 08:24 — with GitHub Actions Inactive

build: updated quill-icons to the latest version

1b340a9

ameerul-deriv commented Feb 9, 2024

View reviewed changes

Merge branch 'niloofar/update-quill-icons-to-the-latest' of github.co…

571cfc7

…m:niloofar-deriv/deriv-app into P2PS-2375-remove-p2p-api-calls-from-dtrader-page

ameerul-deriv had a problem deploying to Preview February 9, 2024 08:33 — with GitHub Actions Failure

ameerul-deriv temporarily deployed to Preview February 9, 2024 08:33 — with GitHub Actions Inactive

fix: failing eslint

c595945

ameerul-deriv temporarily deployed to Preview February 9, 2024 08:47 — with GitHub Actions Inactive

fix: failing testcases

58684c0

ameerul-deriv temporarily deployed to Preview February 9, 2024 09:15 — with GitHub Actions Inactive

farhan-nurzi-deriv previously approved these changes Feb 9, 2024

View reviewed changes

ameerul-deriv marked this pull request as ready for review February 9, 2024 09:37

ameerul-deriv requested review from adrienne-deriv, thisyahlen-deriv, wojciech-deriv, farrah-deriv and nijil-deriv as code owners February 9, 2024 09:37

balakrishna-deriv previously approved these changes Feb 13, 2024

View reviewed changes

nada-deriv approved these changes Feb 13, 2024

View reviewed changes

farrah-deriv reviewed Feb 13, 2024

View reviewed changes

ameerul-deriv added 2 commits February 15, 2024 16:52

fix: POA not showing, user not blocked when going to buy/sell

57d2ce2

fix: merge conflicts

ef1fe37

ameerul-deriv dismissed stale reviews from balakrishna-deriv and farhan-nurzi-deriv via ef1fe37 February 15, 2024 08:59

ameerul-deriv temporarily deployed to Preview February 15, 2024 09:00 — with GitHub Actions Inactive

ameerul-deriv commented Feb 15, 2024

View reviewed changes

nada-deriv approved these changes Feb 15, 2024

View reviewed changes

farrah-deriv previously approved these changes Feb 15, 2024

View reviewed changes

fix: cashier locked not showing immediately

209a102

ameerul-deriv dismissed farrah-deriv’s stale review via 209a102 February 19, 2024 02:21

ameerul-deriv temporarily deployed to Preview February 19, 2024 02:22 — with GitHub Actions Inactive

fix: unsubscribe function console error when logging out

bcc40ee

ameerul-deriv temporarily deployed to Preview February 19, 2024 06:45 — with GitHub Actions Inactive

ameerul-deriv temporarily deployed to Preview February 19, 2024 06:46 — with GitHub Actions Inactive

nada-deriv reviewed Feb 19, 2024

View reviewed changes

packages/p2p/src/pages/my-profile/my-profile.tsx Show resolved Hide resolved

chore: remove unused import

8233e86

ameerul-deriv temporarily deployed to Preview February 19, 2024 08:41 — with GitHub Actions Inactive

fix: delay in showing blocked for p2p

459d435

ameerul-deriv temporarily deployed to Preview February 19, 2024 08:49 — with GitHub Actions Inactive

farrah-deriv approved these changes Feb 21, 2024

View reviewed changes

farrah-deriv merged commit f7261b1 into deriv-com:master Feb 21, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[P2PS] / Ameerul / P2PS-2375 Remove P2P API from DTrader page #13488

[P2PS] / Ameerul / P2PS-2375 Remove P2P API from DTrader page #13488

ameerul-deriv commented Feb 9, 2024

vercel bot commented Feb 9, 2024 •

edited

Loading

ameerul-deriv Feb 9, 2024

ameerul-deriv Feb 9, 2024

ameerul-deriv Feb 9, 2024

ameerul-deriv Feb 9, 2024

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

farrah-deriv Feb 13, 2024

ameerul-deriv Feb 13, 2024

ameerul-deriv Feb 15, 2024

ameerul-deriv Feb 15, 2024

sonarcloud bot commented Feb 19, 2024

[P2PS] / Ameerul / P2PS-2375 Remove P2P API from DTrader page #13488

[P2PS] / Ameerul / P2PS-2375 Remove P2P API from DTrader page #13488

Conversation

ameerul-deriv commented Feb 9, 2024

Changes:

Screenshots:

vercel bot commented Feb 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Feb 19, 2024

Quality Gate passed

vercel bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading