Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTRA / Kate / DTRA-905 / Binary.com reference is still showing in forward starting contract modal #13584

Merged

Conversation

kate-deriv
Copy link
Contributor

Changes:

Removed old company name and update test cases

Screenshots:

Screenshot 2024-02-15 at 13 00 04

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 19, 2024 7:42am

Copy link
Contributor

github-actions bot commented Feb 15, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-905replaceoldname.binary.sx/

@coveralls
Copy link

coveralls commented Feb 15, 2024

Coverage Status

coverage: 36.696% (-0.002%) from 36.698%
when pulling 9895560 on kate-deriv:kate/DTRA-905/replace_old_name
into 6b16c2f on binary-com:master.

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@maryia-deriv maryia-deriv merged commit 9dc8090 into deriv-com:master Feb 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants