-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEQ] P2PV2-share ads component #13649
[FEQ] P2PV2-share ads component #13649
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-feq-1711share-ads-component.binary.sx/ |
@@ -0,0 +1,39 @@ | |||
import React, { useEffect, useState } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
component will be replaced by the one in deriv-com/ui
packages/p2p-v2/src/components/Modals/MyAdsDeleteModal/MyAdsDeleteModal.tsx
Outdated
Show resolved
Hide resolved
packages/p2p-v2/src/components/Modals/ShareAdsModal/ShareAdsCard.scss
Outdated
Show resolved
Hide resolved
packages/p2p-v2/src/pages/my-ads/screens/MyAds/MyAdsTable/MyAdsTable.tsx
Show resolved
Hide resolved
packages/p2p-v2/src/components/Modals/ShareAdsModal/ShareAdsModal.tsx
Outdated
Show resolved
Hide resolved
packages/p2p-v2/src/components/Modals/ShareAdsModal/ShareAdsCard.tsx
Outdated
Show resolved
Hide resolved
packages/p2p-v2/src/components/Modals/ShareAdsModal/ShareAdsModal.tsx
Outdated
Show resolved
Hide resolved
packages/p2p-v2/src/components/Modals/ShareAdsModal/ShareAdsModal.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Changes:
Share ads modal => desktop + responsive with unit test
Screenshots:
Please provide some screenshots of the change.
Screen.Recording.2024-02-20.at.4.54.39.PM.mov