Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] P2PV2-share ads component #13649

Merged

Conversation

nada-deriv
Copy link
Contributor

@nada-deriv nada-deriv commented Feb 19, 2024

Changes:

Share ads modal => desktop + responsive with unit test
Screenshot 2024-02-20 at 4 58 23 PM

Screenshots:

Please provide some screenshots of the change.

Screen.Recording.2024-02-20.at.4.54.39.PM.mov

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 21, 2024 7:26am

Copy link
Contributor

github-actions bot commented Feb 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13649](https://github.com/binary-com/deriv-app/pull/13649)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-feq-1711share-ads-component.binary.sx?qa_server=red.derivws.com&app_id=24164
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-feq-1711share-ads-component.binary.sx
- **App ID**: `24164`

Copy link
Contributor

github-actions bot commented Feb 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-feq-1711share-ads-component.binary.sx/

@@ -0,0 +1,39 @@
import React, { useEffect, useState } from 'react';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component will be replaced by the one in deriv-com/ui

@coveralls
Copy link

coveralls commented Feb 19, 2024

Coverage Status

coverage: 36.9% (+0.06%) from 36.841%
when pulling a10edc4 on nada-deriv:nada/FEQ-1711/share-ads-component
into f7261b1 on binary-com:master.

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
12.2% Duplication on New Code

See analysis details on SonarCloud

@farrah-deriv farrah-deriv merged commit 7eb01c8 into deriv-com:master Feb 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants