Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ako/ prevent remote config url error on local development #13668

Conversation

ali-hosseini-deriv
Copy link
Member

Changes:

In case the app is running on local we dont need to have access to remote config url and therefore the error is not needed. so i just removed that error from the local development server.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 19, 2024 10:02am

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
17.7% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 36.706% (-0.003%) from 36.709%
when pulling dee5bf8 on ali-hosseini-deriv:ako/FEQ-1504/prevent-remote-config-url-error-on-local
into 57cc084 on binary-com:master.

@ali-hosseini-deriv ali-hosseini-deriv merged commit 04bac26 into deriv-com:master Feb 19, 2024
5 of 6 checks passed
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13668](https://github.com/binary-com/deriv-app/pull/13668)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-1504preven-838f96.binary.sx?qa_server=red.derivws.com&app_id=24195
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-1504preven-838f96.binary.sx
- **App ID**: `24195`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-1504preven-838f96.binary.sx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants