-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ako/ prevent remote config url error on local development #13668
Merged
ali-hosseini-deriv
merged 1 commit into
deriv-com:master
from
ali-hosseini-deriv:ako/FEQ-1504/prevent-remote-config-url-error-on-local
Feb 19, 2024
Merged
Ako/ prevent remote config url error on local development #13668
ali-hosseini-deriv
merged 1 commit into
deriv-com:master
from
ali-hosseini-deriv:ako/FEQ-1504/prevent-remote-config-url-error-on-local
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-hosseini-deriv
requested review from
adrienne-deriv,
thisyahlen-deriv,
farhan-nurzi-deriv and
wojciech-deriv
as code owners
February 19, 2024 09:15
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ali-hosseini-deriv
temporarily deployed
to
Preview
February 19, 2024 09:15
— with
GitHub Actions
Inactive
ali-hosseini-deriv
temporarily deployed
to
Preview
February 19, 2024 09:15
— with
GitHub Actions
Inactive
Quality Gate passedIssues Measures |
hamza-deriv
approved these changes
Feb 19, 2024
maryia-deriv
approved these changes
Feb 19, 2024
hirad-deriv
approved these changes
Feb 19, 2024
matin-deriv
approved these changes
Feb 19, 2024
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-1504preven-838f96.binary.sx/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
In case the app is running on local we dont need to have access to remote config url and therefore the error is not needed. so i just removed that error from the local development server.
Screenshots:
Please provide some screenshots of the change.