Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] P2P-V2 daily limit modal test #13669

Merged

Conversation

adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Added test cases for daily limit modal
Screenshot 2024-02-19 at 5 28 56 PM

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 19, 2024 10:21am

Copy link
Contributor

github-actions bot commented Feb 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13669](https://github.com/binary-com/deriv-app/pull/13669)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-daily-limit-modal-test.binary.sx?qa_server=red.derivws.com&app_id=31229
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-daily-limit-modal-test.binary.sx
- **App ID**: `31229`

Copy link
Contributor

github-actions bot commented Feb 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-p2p-v2-daily-limit-modal-test.binary.sx/

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
13.4% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Feb 19, 2024

Coverage Status

coverage: 36.718% (+0.009%) from 36.709%
when pulling f69c062 on adrienne-deriv:p2p-v2-daily-limit-modal-test
into 57cc084 on binary-com:master.

@farrah-deriv farrah-deriv merged commit 3b8521f into deriv-com:master Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants