Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-3178 & WALL-3316 / Wallets cashier locked #13753

Merged

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Added CashierLocked and CashierLockedContent components
  • Added unit test for CashierLocked and CashierLockedContent
  • Moved locked scenarios from screens to modules
  • Wrapped deposit, withdrawal, fiat onramp and transfer modules in CashierLocked
  • Added wrapper to deposit, withdrawal, fiat onramp and transfer module unit tests

Screenshots:

Screenshot 2024-02-22 at 5 08 57 PM Screenshot 2024-02-22 at 5 11 44 PM

image

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 22, 2024 11:42am

Copy link
Contributor

github-actions bot commented Feb 22, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13753](https://github.com/binary-com/deriv-app/pull/13753)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3178-wallets-cashie-993d94.binary.sx?qa_server=red.derivws.com&app_id=24219
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3178-wallets-cashie-993d94.binary.sx
- **App ID**: `24219`

Copy link
Contributor

github-actions bot commented Feb 22, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3178-wallets-cashie-993d94.binary.sx/

@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 37.284% (+0.2%) from 37.048%
when pulling 3a7eb4b on lubega-deriv:WALL-3178/wallets-cashier-locked
into d544012 on binary-com:master.

Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nijil-deriv nijil-deriv merged commit ec17a5f into deriv-com:master Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants