Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL-3503] wojtek/sync api with api-v2 ahead of switching the packages #13754

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

wojciech-deriv
Copy link
Contributor

No functional changes. Only re-applied changes from v1 to v2 ahead of switching.

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 22, 2024 10:44am

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13754](https://github.com/binary-com/deriv-app/pull/13754)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-wojciech-deriv-feature-api-sync.binary.sx?qa_server=red.derivws.com&app_id=32114
    - **Original**: https://deriv-app-git-fork-wojciech-deriv-feature-api-sync.binary.sx
- **App ID**: `32114`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-api-sync.binary.sx/

@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 37.608% (+0.4%) from 37.232%
when pulling dab5f51 on wojciech-deriv:feature/api-sync
into e839280 on binary-com:master.

Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
10.3% Duplication on New Code

See analysis details on SonarCloud

@wojciech-deriv wojciech-deriv changed the title wojtek/sync api with api-v2 ahead of switching the packages [WALL-3503] wojtek/sync api with api-v2 ahead of switching the packages Feb 26, 2024
@nijil-deriv nijil-deriv merged commit 5905a61 into deriv-com:master Feb 26, 2024
9 checks passed
Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants