Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/TRAH-2997/chore: fix terms and conditions link to deriv com when user changes language #13878

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Fix redirection link when user change language and clicks on terms and condition in jurisdiction modal

Screenshots:

Screen.Recording.2024-02-29.at.9.17.58.AM.mov

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 29, 2024 2:15am

Copy link
Contributor

github-actions bot commented Feb 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13878](https://github.com/binary-com/deriv-app/pull/13878)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-2997-0a6911.binary.sx?qa_server=red.derivws.com&app_id=24204
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-2997-0a6911.binary.sx
- **App ID**: `24204`

Copy link
Contributor

github-actions bot commented Feb 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-2997-0a6911.binary.sx/

Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hirad-deriv hirad-deriv merged commit 4acf7c4 into deriv-com:master Feb 29, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants