Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOT] sandeep/bot-1164/ts-migration--stores #14021

Merged
merged 8 commits into from
Mar 20, 2024
Merged

[BOT] sandeep/bot-1164/ts-migration--stores #14021

merged 8 commits into from
Mar 20, 2024

Conversation

sandeep-deriv
Copy link
Contributor

@sandeep-deriv sandeep-deriv commented Mar 7, 2024 •
edited
Loading

Change ⚡

Migrate and refactor the following store to TS 🤛

  • Removed download-store
  • flyout-help-store
  • google-drive-store

@boring-cyborg boring-cyborg bot added the Bot label Mar 7, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 20, 2024 6:26am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/14021](https://github.com/binary-com/deriv-app/pull/14021)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-1164ts-migr-1cf113.binary.sx?qa_server=red.derivws.com&app_id=32694
    - **Original**: https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-1164ts-migr-1cf113.binary.sx
- **App ID**: `32694`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-1164ts-migr-1cf113.binary.sx/

@coveralls
Copy link

coveralls commented Mar 7, 2024 •
edited
Loading

Coverage Status

coverage: 38.08% (+0.6%) from 37.501%
when pulling cbf5c33 on sandeep-deriv:sandeep/bot-1164/ts-migration-stores
into 151cf93 on binary-com:master.

farabi-deriv
farabi-deriv previously approved these changes Mar 15, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.6% Duplication on New Code

See analysis details on SonarCloud

@sandeep-deriv sandeep-deriv merged commit 602fa86 into deriv-com:master Mar 20, 2024
5 of 6 checks passed
Dhruv-deriv pushed a commit to Dhruv-deriv/deriv-app that referenced this pull request Mar 20, 2024
@sandeep-deriv @Dhruv-deriv
[BOT] sandeep/bot-1164/ts-migration--stores (deriv-com#14021)
94e76ff 
* refactor: ⚡ refactoring download-store and migrating it to TS

* refactor: 🚧 Migrated stores to TS along with the config

* chore: ⚡ cleanup and fixed sonarcloud code smells

* refactor: ⚡ removed download store and instead made utitlity methods

---------

Co-authored-by: Sandeep <sandeepsingh@Sandeep-Singhs-Mac-CX9PCJX3L9-Standard.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafin-deriv shafin-deriv shafin-deriv approved these changes

@rupato-deriv rupato-deriv rupato-deriv approved these changes

@farabi-deriv farabi-deriv farabi-deriv left review comments

@vinu-deriv vinu-deriv Awaiting requested review from vinu-deriv

Assignees
No one assigned
Labels
Bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sandeep-deriv @coveralls @rupato-deriv @farabi-deriv @shafin-deriv