Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2PS] / Ameerul / Remove the default value for exchange rate #14988

Conversation

ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Removed default value for exchange rate

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 6, 2024 3:00am

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
8.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 6, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14988](https://github.com/binary-com/deriv-app/pull/14988)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2844-remove-the-de-0b94e1.binary.sx?qa_server=red.derivws.com&app_id=24041
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2844-remove-the-de-0b94e1.binary.sx
- **App ID**: `24041`

Copy link
Contributor

github-actions bot commented May 6, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-2844-remove-the-de-0b94e1.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 40.514%. remained the same
when pulling b01b504 on ameerul-deriv:P2PS-2844-remove-the-default-value-for-exchange-rate
into 77f9864 on binary-com:master.

@farrah-deriv farrah-deriv merged commit 29562a7 into deriv-com:master Jun 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants