Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DTRA] henry/dtra-1237/fix: dtrader-v2 setup #14991
[DTRA] henry/dtra-1237/fix: dtrader-v2 setup #14991
Changes from 5 commits
5baf11b
8632910
f450178
a509a82
1593a82
8db429d
776d53a
61c1088
7b25581
8b8fd1e
b6746b6
ac0ec49
b64ff30
01214a6
07af4f6
8ecea00
7bd0965
ddec755
fc3d244
5bf1def
86401fe
3cc68db
db600a9
7501931
fe98975
e706195
9fbaa8b
2e9e896
9f16083
6dc46c3
80b13f6
93b528c
9b72174
41f986f
78d8e6c
8efb948
2367b75
bf975ac
ec8b9b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use quill token here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we are waiting for prince to turn quill-tokens into a library. So that i can put quill-token library in package.json and use the tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use quill token here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click on the icon, it doesn't change the color. Same for 'menu'. Should it change or not? Because half of the icons do it, half - not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah currently in discussion with quill-icons team to allow fill for Legacy icons. They allow fill/color-change for standalone and some other icons but not legacy icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May we use
i18n_default_text
askey
(item.label.props.i18n_default_text
)? Not sure if it works, but sonarCloud is complainingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but maybe we need to use
<Text/>
instead of<CaptionText/>
? It will help to get rid of color propThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just above where you've underline it says
mobile/semantic/typography/caption/regular/default. Not sure what to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use quill token here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use quill token here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align-self
won't work with flex-container (only with flex items), so it can be deleted without any consequences I guessThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it track changes in such huge object as
root_store
? Please, ignore if irrelevantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i copied pasta app.tsx in AppV1. Not entirely sure what its doing tbh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kate-deriv React.useEffect will just track the reference of the object and it won't track the nested props. So, this code is safe in terms of performance.