Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [UPM-1080]/evgeniy/refactor passkeys code, rename flow #15237

Conversation

yauheni-deriv
Copy link
Contributor

@yauheni-deriv yauheni-deriv commented May 18, 2024

Changes:

refactored logic in main file,
config is split to separate components to increase readability.
changed the logic for effortless modal to reduce unnecessary api calls.
Implemented rename flow.

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 10, 2024 0:41am

Copy link
Contributor

github-actions bot commented May 18, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15237](https://github.com/binary-com/deriv-app/pull/15237)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-evgeniyupm-1080refactor-766ede.binary.sx?qa_server=red.derivws.com&app_id=32511
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-evgeniyupm-1080refactor-766ede.binary.sx
- **App ID**: `32511`

Copy link
Contributor

github-actions bot commented May 18, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-evgeniyupm-1080refactor-766ede.binary.sx/

@coveralls
Copy link

coveralls commented May 20, 2024

Coverage Status

coverage: 43.56% (+0.02%) from 43.543%
when pulling 95f66fb on yauheni-deriv:evgeniy_upm-1080_refactor-passkeys-code
into b7e377d on binary-com:master.

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Generating Lighthouse report...

@amina-deriv amina-deriv merged commit 132ea1f into deriv-com:master Jun 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants