Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEBREL]/Mitra/[WEBREL-2748] Remove the condition as we use the component for bot… #15309

Merged
merged 2 commits into from
May 22, 2024
Merged

[WEBREL]/Mitra/[WEBREL-2748] Remove the condition as we use the component for bot… #15309

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86635b9
fix: :ambulance: remove the condition as we use the component for bot…
mitra-deriv May 22, 2024
784853e
fix: :bug: remove passing the props
mitra-deriv May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/appstore/src/components/containers/listing-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ type TListingContainerProps = {
type TOptionsProps = Pick<TListingContainerProps, 'title' | 'description' | 'is_deriv_platform'>;
type TSwitcherProps = Pick<TListingContainerProps, 'is_deriv_platform'>;

const Options = ({ title, description, is_deriv_platform }: TOptionsProps) => {
if (!is_deriv_platform) return null;

const Options = ({ title, description }: TOptionsProps) => {
Copy link
Contributor Author

@mitra-deriv mitra-deriv May 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the is_deriv_platform as we are using the component in both CFD and option section

mitra-deriv marked this conversation as resolved.
Show resolved Hide resolved
return (
<div className='listing-container__title'>
{title}
Expand Down