Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COJ-1230]/Amina/feat: remove accout-v2 from deriv-app #15450

Merged

Conversation

amina-deriv
Copy link
Contributor

Changes:

Removing account-v2 from deriv-app codebase

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 4, 2024 6:57am

Copy link
Contributor

github-actions bot commented Jun 1, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15450](https://github.com/binary-com/deriv-app/pull/15450)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-coj-1230removeaccountv2.binary.sx?qa_server=red.derivws.com&app_id=32877
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-coj-1230removeaccountv2.binary.sx
- **App ID**: `32877`

Copy link
Contributor

github-actions bot commented Jun 1, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-coj-1230removeaccountv2.binary.sx/

likhith-deriv
likhith-deriv previously approved these changes Jun 3, 2024
matin-deriv
matin-deriv previously approved these changes Jun 4, 2024
@matin-deriv
Copy link
Contributor

@amina-deriv, just a quick question: Are there any hooks in the accounts-v2 package that will remain unused after your changes?

@amina-deriv amina-deriv force-pushed the amina/COJ-1230/remove_account_v2 branch from 3be9709 to 43bec0a Compare June 4, 2024 06:05
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@amina-deriv amina-deriv merged commit ea75dbc into deriv-com:master Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants