Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFDS]/Hasan/CFDS-4206/Cfd package bundle size reduction #15747

Merged

Conversation

hasan-deriv
Copy link
Contributor

@hasan-deriv hasan-deriv commented Jun 24, 2024

Changes:

  • Moved all deriv packages to external
  • Moved some external packages to the external, which can be accessed from @deriv/core or @deriv/appstore.
  • Removed unused packages
  • Removed unused entries
  • Created separate chunks for shared modules and assets. Such as: SVG icons, helpers, constants and store utility
  • Enabled Tree Shaking
  • Added some lazy loading to see the metrics, more lazy loading will be added to check how much impact would these changes have

Previous bundle size:

Stat - 23.19 MB
Parsed - 21.45 MB
Gzipped - 4.56 MB

Current Bundle size:

Stat - 2.61 MB
Parsed - 975.43 KB
Gzipped - 570.97 KB

Screenshots:

Screenshot 2024-07-03 at 3 22 39 PM Screenshot 2024-07-03 at 10 28 41 AM

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 18, 2024 3:05am

Copy link
Contributor

github-actions bot commented Jun 24, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-hasan-deriv-hasan-cfd-bundle-size-reduction.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 45.428% (+0.004%) from 45.424%
when pulling e088087 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 94644cd on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.428% (+0.004%) from 45.424%
when pulling e088087 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 94644cd on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.43% (+0.006%) from 45.424%
when pulling 1497d8d on hasan-deriv:hasan/cfd-bundle-size-reduction
into 94644cd on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.552% (+0.1%) from 45.424%
when pulling 03196b1 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 94644cd on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.53% (+0.1%) from 45.424%
when pulling 3129e58 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 94644cd on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 34.822% (-10.6%) from 45.424%
when pulling 7f15432 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 94644cd on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9685922 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9685922 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9685922 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.921% (-0.6%) from 45.525%
when pulling d7fd9f5 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 44.921% (-0.6%) from 45.525%
when pulling d7fd9f5 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.921% (-0.6%) from 45.525%
when pulling d7fd9f5 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.921% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 44.921% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.921% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.924% (-0.6%) from 45.525%
when pulling 9ba71d7 on hasan-deriv:hasan/cfd-bundle-size-reduction
into 75288e7 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.768% (-0.01%) from 45.778%
when pulling eeaec49 on hasan-deriv:hasan/cfd-bundle-size-reduction
into ffc9dda on binary-com:master.

@farrah-deriv farrah-deriv merged commit 5e33460 into deriv-com:master Jul 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants