Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFDS]/Hasan/CFDS-4165/Update STN abbreviation to STD on Trader's Hub & Wallets #16029

Merged

Conversation

hasan-deriv
Copy link
Contributor

@hasan-deriv hasan-deriv commented Jul 10, 2024

Changes:

  • Updated standard icons for compare accounts, mt5 accounts, cashier and migration flow from traders hub
  • Updated mt5 drv icon to mt5 std icon

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 25, 2024 9:19am

Copy link
Contributor

github-actions bot commented Jul 10, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16029](https://github.com/binary-com/deriv-app/pull/16029)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hasan-deriv-hasan-cfds-4165update-stn-abbr.binary.sx?qa_server=red.derivws.com&app_id=32466
    - **Original**: https://deriv-app-git-fork-hasan-deriv-hasan-cfds-4165update-stn-abbr.binary.sx
- **App ID**: `32466`

Copy link
Contributor

github-actions bot commented Jul 10, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-hasan-deriv-hasan-cfds-4165update-stn-abbr.binary.sx/

@coveralls
Copy link

coveralls commented Jul 10, 2024

Coverage Status

coverage: 46.035% (+0.2%) from 45.876%
when pulling 6acd329 on hasan-deriv:hasan/CFDS-4165/update-stn-abbr
into 115b8cb on binary-com:master.

Copy link

sonarcloud bot commented Jul 25, 2024

Copy link
Contributor

Generating Lighthouse report...

@farrah-deriv farrah-deriv merged commit 3fe82cf into deriv-com:master Jul 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants