Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is unable to exit from the flow when trying to access the verification link for change email flow from another logged out device #16033

Conversation

utkarsha-deriv
Copy link
Contributor

@utkarsha-deriv utkarsha-deriv commented Jul 10, 2024

Changes:

  • added a condition to redirect the user to login page if they try to reset email in logged out state( eg, trying to reset email by clicking on the link from another device where user is logged out)
  • sets the key in sessionStorage so that we can grab the value even after the code gets removed from localstorage and url

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 30, 2024 11:07am

Copy link
Contributor

github-actions bot commented Jul 10, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16033](https://github.com/binary-com/deriv-app/pull/16033)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-utkarsha-deriv-utkarsha-fix-redirectu-a1f94f.binary.sx?qa_server=red.derivws.com&app_id=23820
    - **Original**: https://deriv-app-git-fork-utkarsha-deriv-utkarsha-fix-redirectu-a1f94f.binary.sx
- **App ID**: `23820`

Copy link
Contributor

github-actions bot commented Jul 10, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 36
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-utkarsha-deriv-utkarsha-fix-redirectu-a1f94f.binary.sx/

@coveralls
Copy link

coveralls commented Jul 10, 2024

Coverage Status

coverage: 46.342% (+0.08%) from 46.267%
when pulling 18875ee on utkarsha-deriv:utkarsha/fix-redirectURL-code-issue-in-change-email-flow-on-logout
into 1486143 on binary-com:master.

@utkarsha-deriv utkarsha-deriv changed the title fix: fix redirectURL code fix User is unable to exit from the flow when trying to access the verification link for change email flow from another logged out device Jul 12, 2024
amina-deriv
amina-deriv previously approved these changes Jul 12, 2024
likhith-deriv
likhith-deriv previously approved these changes Jul 12, 2024
Copy link

sonarcloud bot commented Jul 30, 2024

Copy link
Contributor

Generating Lighthouse report...

@amina-deriv amina-deriv merged commit 1cb4ca2 into deriv-com:master Aug 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants