Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suisin/chore: added yml file to ease deployment for passkey #16216

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Added yml file to ease deployment for passkey from FE

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 26, 2024 7:50am

Copy link
Contributor

github-actions bot commented Jul 26, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16216](https://github.com/binary-com/deriv-app/pull/16216)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-createbuilddocker-368160.binary.sx?qa_server=red.derivws.com&app_id=32205
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-createbuilddocker-368160.binary.sx
- **App ID**: `32205`

Copy link
Contributor

github-actions bot commented Jul 26, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 38
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-createbuilddocker-368160.binary.sx/

Copy link

sonarcloud bot commented Jul 26, 2024

matin-deriv
matin-deriv previously approved these changes Jul 26, 2024
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suisin-deriv suisin-deriv changed the base branch from master to build_docker_passkey_image July 26, 2024 07:59
@coveralls
Copy link

coveralls commented Jul 26, 2024

Coverage Status

coverage: 46.23% (-0.004%) from 46.234%
when pulling f082734 on suisin-deriv:suisin/create_build_docker_passkey_image_yml
into 65ee6ec on binary-com:master.

@suisin-deriv suisin-deriv changed the base branch from build_docker_passkey_image to master July 26, 2024 08:00
@suisin-deriv suisin-deriv dismissed matin-deriv’s stale review July 26, 2024 08:00

The base branch was changed.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Generating Lighthouse report...

@ali-hosseini-deriv ali-hosseini-deriv merged commit e60c35a into deriv-com:master Jul 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants