Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Jim/WALL-2869/add test cases for desktop wallets list component #16528

Conversation

jim-deriv
Copy link
Contributor

Changes:

  • Added test cases for DesktopWalletsList component

Screenshots:

image

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 20, 2024 5:17am

Copy link
Contributor

github-actions bot commented Aug 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16528](https://github.com/binary-com/deriv-app/pull/16528)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-wall-2869test-cases-for-2c3c07.binary.sx?qa_server=red.derivws.com&app_id=31531
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-wall-2869test-cases-for-2c3c07.binary.sx
- **App ID**: `31531`

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 34
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-wall-2869test-cases-for-2c3c07.binary.sx/

@coveralls
Copy link

coveralls commented Aug 19, 2024

Coverage Status

coverage: 46.276% (+0.02%) from 46.261%
when pulling 81ad8e7 on jim-deriv:jim/wall-2869/test-cases-for-desktop-wallets-list-component
into 5f6c23b on binary-com:master.

wojciech-deriv
wojciech-deriv previously approved these changes Aug 19, 2024
Copy link

sonarcloud bot commented Aug 20, 2024

@jim-deriv jim-deriv merged commit ae6f134 into deriv-com:master Aug 20, 2024
8 checks passed
@jim-deriv jim-deriv deleted the jim/wall-2869/test-cases-for-desktop-wallets-list-component branch August 20, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants