Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-4791 / Wallets RTL support for اللغة العربية (AR) #16660

Merged

Conversation

lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Aug 29, 2024

Changes:

  • Enable language switcher in footer, mobile menu and account settings for Wallets with only EN and AR
  • Added dynamic css properties to wallets design for RTL support
  • Added useIsRtl hook
  • Fix localize functions to translate texts on language switch
  • Added logic to redirect back to EN if other languages besides EN or AR are inputted

Screenshots:

Screen.Recording.2024-09-04.at.2.26.43.PM.mov
image image image image image

Language switching:

Screen.Recording.2024-09-02.at.11.57.34.AM.mov

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 30, 2024 11:21am

Copy link
Contributor

github-actions bot commented Aug 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16660](https://github.com/binary-com/deriv-app/pull/16660)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-4791-wallets-rtl-support.binary.sx?qa_server=red.derivws.com&app_id=32511
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-4791-wallets-rtl-support.binary.sx
- **App ID**: `32511`

Copy link
Contributor

github-actions bot commented Aug 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with undefined

@coveralls
Copy link

coveralls commented Aug 30, 2024

Coverage Status

coverage: 53.507% (+0.02%) from 53.491%
when pulling ec23639 on lubega-deriv:WALL-4791/wallets-rtl-support
into 44b6901 on binary-com:master.

Copy link

sonarcloud bot commented Sep 30, 2024

@nijil-deriv nijil-deriv merged commit 342cb06 into deriv-com:master Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants