Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WALL] Lubega / WALL-4837 / MT5 reset password responsive broken header #16722

Merged
merged 6 commits into from
Sep 9, 2024
Merged

[WALL] Lubega / WALL-4837 / MT5 reset password responsive broken header #16722

merged 6 commits into from
Sep 9, 2024

Conversation

lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Sep 4, 2024 •
edited
Loading

Changes:

  • Fix broken header in MT5 reset password responsive screen
  • Update strings format for WIthdrawalCryptoDisclaimer, WithdrawalCryptoReceipt and CompareAccountsDescription for crowdin integration
  • Added localize to MT5 trade details constants

Screenshots (Bug VS Fix):

364201265-837c168b-6743-4aa7-8a29-1e7643da9770

@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 9, 2024 6:29am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/16722](https://github.com/binary-com/deriv-app/pull/16722)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-4837-mt5-reset-pass-62aeeb.binary.sx?qa_server=red.derivws.com&app_id=24166
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-4837-mt5-reset-pass-62aeeb.binary.sx
- **App ID**: `24166`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-4837-mt5-reset-pass-62aeeb.binary.sx/

@coveralls
Copy link

coveralls commented Sep 4, 2024 •
edited
Loading

Coverage Status

coverage: 47.213% (-0.002%) from 47.215%
when pulling f90b652 on lubega-deriv:WALL-4837/mt5-reset-password-broken-header
into 186ab98 on binary-com:master.

aizad-deriv
aizad-deriv previously approved these changes Sep 4, 2024
View reviewed changes
jim-deriv
jim-deriv previously approved these changes Sep 4, 2024
View reviewed changes
jim-deriv
jim-deriv previously approved these changes Sep 4, 2024
View reviewed changes
heorhi-deriv
heorhi-deriv previously approved these changes Sep 4, 2024
View reviewed changes
wojciech-deriv
wojciech-deriv previously approved these changes Sep 4, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

⏳ Generating Lighthouse report...