Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suisin/utkarsha/upm819/phone verification flow #16781

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Deploy PNV changes to UAT

Screenshots:

Please provide some screenshots of the change.

suisin-deriv and others added 30 commits June 24, 2024 15:05
…ub.com:suisin-deriv/deriv-app into suisin/UPM1058/api_integration_and_flows
…ub.com:suisin-deriv/deriv-app into suisin/UPM1058/api_integration_and_flows
…ion_and_flows

Suisin/upm1058/api integration and flows
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 10, 2024 7:00am

Copy link

gitguardian bot commented Sep 10, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13098339 Triggered Generic Password f000ee6 packages/core/src/App/Containers/ResetPasswordModal/tests/reset-password-modal.spec.tsx View secret
13098339 Triggered Generic Password f000ee6 packages/core/src/App/Containers/ResetPasswordModal/tests/reset-password-modal.spec.tsx View secret
13098339 Triggered Generic Password f000ee6 packages/core/src/App/Containers/ResetPasswordModal/tests/reset-password-modal.spec.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@amina-deriv amina-deriv merged commit ae5205b into deriv-com:suisin/phone_number_verification_uat Sep 10, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants