Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTRA-1902 / Kate / [DTrader-V2] Video seek timer bug when dragged to a different timestamp #16854

Merged

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Sep 16, 2024

Changes:

  • Used hook for debounce and wrapped dragmove handler with throttle
  • Increased drag area (controlled via prop)
  • Added fixed height and width for video preview container (avoiding jumping content during loading)
  • Added tests

Screenshots:

Screen.Recording.2024-09-17.at.4.11.12.PM.mov

Please provide some screenshots of the change.

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 24, 2024 1:34pm

Copy link
Contributor

github-actions bot commented Sep 16, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16854](https://github.com/binary-com/deriv-app/pull/16854)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1902videoplayerfixes.binary.sx?qa_server=red.derivws.com&app_id=31581
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1902videoplayerfixes.binary.sx
- **App ID**: `31581`

Copy link
Contributor

github-actions bot commented Sep 16, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with undefined

@coveralls
Copy link

coveralls commented Sep 16, 2024

Coverage Status

coverage: 52.819% (+0.4%) from 52.447%
when pulling 04cd728 on kate-deriv:kate/DTRA-1902/video_player_fixes
into 4405123 on binary-com:master.

vinu-deriv
vinu-deriv previously approved these changes Sep 18, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

Copy link
Contributor

Generating Lighthouse report...

@vinu-deriv vinu-deriv merged commit 9b90400 into deriv-com:master Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants