carol/ P2P: Payment method #4087

carolsachdeva · 2021-10-07T13:08:03Z

No description provided.

vercel · 2021-10-07T13:08:08Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/nZSc6gXxWYTeHfiV4Gcb1Qdeg2An
✅ Preview: https://deriv-app-git-fork-carol-binary-payment-methods.binary.sx

github-actions · 2021-10-07T13:17:43Z

A production App ID was automatically generated for this PR. (log)

PR: carol/ P2P: Payment method #4087
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-carol-binary-payment-methods.binary.sx?qa_server=frontend.binaryws.com&app_id=24257
- Original: https://deriv-app-git-fork-carol-binary-payment-methods.binary.sx
App ID: 24257

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/4087](https://github.com/binary-com/deriv-app/pull/4087)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-carol-binary-payment-methods.binary.sx?qa_server=frontend.binaryws.com&app_id=24257
    - **Original**: https://deriv-app-git-fork-carol-binary-payment-methods.binary.sx
- **App ID**: `24257`

sonarcloud · 2021-10-12T08:15:14Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
1.8% Duplication

sonarcloud · 2021-11-11T12:30:17Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
1.8% Duplication

…-methods

yashim-deriv

LGTM

balakrishna-deriv · 2022-01-06T05:54:13Z

packages/components/src/components/icon/cashier/ic-cashier-vertical-ellipsis.svg

@@ -0,0 +1,5 @@
+<svg width="2" height="10" viewBox="0 0 2 10" fill="none" xmlns="http://www.w3.org/2000/svg">


balakrishna-deriv · 2022-01-06T06:09:19Z

packages/p2p/src/stores/order-store.js

@@ -26,6 +26,7 @@ export default class OrderStore {
    @observable orders = [];
    @observable order_id = null;
    @observable order_rerender_timeout = null;
+    // @observable payment_method_accordion_details = [];


can we remove the unused props?

…nto p2p

PM detail validation regex regeneration photosynthesis

fixed crashing and burning create ad modal

…iv-app into payment-methods

…nto p2p

added dashing dash to ad table

PM minor fixes

Fix: empty spacing in advertisement and buy-sell page

sonarcloud · 2022-02-25T08:45:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.8% Duplication

boring-cyborg bot added the P2P label Oct 7, 2021

vercel bot deployed to Preview October 7, 2021 13:08 View deployment

boring-cyborg bot added the Components label Oct 12, 2021

vercel bot deployed to Preview October 12, 2021 08:11 View deployment

vercel bot deployed to Preview November 11, 2021 12:26 View deployment

vercel bot deployed to Preview December 16, 2021 18:59 View deployment

vercel bot deployed to Preview December 24, 2021 08:21 View deployment

payment methods contd.

44e0819

vercel bot deployed to Preview December 27, 2021 07:37 View deployment

fix: conflicts

5c976b7

vercel bot deployed to Preview December 28, 2021 06:04 View deployment

fix: error

e3e1fbd

vercel bot deployed to Preview December 28, 2021 07:41 View deployment

carolsachdeva marked this pull request as ready for review December 29, 2021 08:40

carolsachdeva requested review from balakrishna-deriv, matin-deriv and nijil-deriv as code owners December 29, 2021 08:40

Carol Sachdeva added 2 commits January 6, 2022 05:21

payment methods contd.

2fee7f9

Merge branch 'master' of github.com:binary-com/deriv-app into payment…

abefdc8

…-methods

vercel bot deployed to Preview January 5, 2022 21:23 View deployment

yashim-deriv previously approved these changes Jan 6, 2022

View reviewed changes

balakrishna-deriv reviewed Jan 6, 2022

View reviewed changes

balakrishna-deriv previously approved these changes Jan 6, 2022

View reviewed changes

fix: raised issues

2bad8f0

carolsachdeva dismissed balakrishna-deriv’s stale review via 2bad8f0 January 12, 2022 03:26

Khalid Ibrahim and others added 2 commits February 24, 2022 19:42

Merge branch 'payment-methods' of github.com:carol-binary/deriv-app i…

da69f0f

…nto p2p

Merge pull request #32 from khalid-deriv/p2p

1eeb573

PM detail validation regex regeneration photosynthesis

vercel bot deployed to Preview February 24, 2022 12:19 View deployment

fix: error message

f3adbe6

vercel bot deployed to Preview February 24, 2022 13:40 View deployment

Khalid Ibrahim and others added 2 commits February 24, 2022 22:18

fixed crashing and burning create ad modal

0c7b94b

Merge pull request #33 from khalid-deriv/p2p

ea95db5

fixed crashing and burning create ad modal

vercel bot deployed to Preview February 24, 2022 14:23 View deployment

akmal-deriv and others added 3 commits February 25, 2022 11:03

Merge branch 'payment-methods' of https://github.com/carol-binary/der…

c108c8b

…iv-app into payment-methods

Fix: buy-sell row padding

6b34f9b

quick add error message

18e534c

vercel bot deployed to Preview February 25, 2022 03:34 View deployment

sell form button

c604170

vercel bot deployed to Preview February 25, 2022 04:12 View deployment

akmal-deriv and others added 5 commits February 25, 2022 12:14

Change modal title for add PM modal

4b854ae

Merge branch 'payment-methods' of https://github.com/carol-binary/der…

95627c9

…iv-app into payment-methods

added dashing dash to ad table

120750b

Merge branch 'payment-methods' of github.com:carol-binary/deriv-app i…

787f626

…nto p2p

Merge pull request #36 from khalid-deriv/p2p

863f6b9

added dashing dash to ad table

vercel bot deployed to Preview February 25, 2022 06:11 View deployment

Merge pull request #35 from akmal-binary/payment-methods

9a4157b

PM minor fixes

vercel bot deployed to Preview February 25, 2022 06:26 View deployment

fix: minor issues

216db99

vercel bot deployed to Preview February 25, 2022 06:37 View deployment

akmal-deriv and others added 3 commits February 25, 2022 15:56

Fix: empty spacing in advertisement and buy-sell page

067fa81

Remove an article

b829e49

Merge pull request #37 from akmal-binary/payment-methods

acaf1ec

Fix: empty spacing in advertisement and buy-sell page

vercel bot deployed to Preview February 25, 2022 08:41 View deployment

carolsachdeva merged commit 0530234 into deriv-com:master Mar 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

carol/ P2P: Payment method #4087

carol/ P2P: Payment method #4087

carolsachdeva commented Oct 7, 2021

vercel bot commented Oct 7, 2021 •

edited

Loading

github-actions bot commented Oct 7, 2021 •

edited

Loading

sonarcloud bot commented Oct 12, 2021

sonarcloud bot commented Nov 11, 2021

yashim-deriv left a comment

balakrishna-deriv Jan 6, 2022

balakrishna-deriv Jan 6, 2022

sonarcloud bot commented Feb 25, 2022

		@@ -0,0 +1,5 @@
		<svg width="2" height="10" viewBox="0 0 2 10" fill="none" xmlns="http://www.w3.org/2000/svg">

carol/ P2P: Payment method #4087

carol/ P2P: Payment method #4087

Conversation

carolsachdeva commented Oct 7, 2021

vercel bot commented Oct 7, 2021 • edited Loading

github-actions bot commented Oct 7, 2021 • edited Loading

sonarcloud bot commented Oct 12, 2021

sonarcloud bot commented Nov 11, 2021

yashim-deriv left a comment

Choose a reason for hiding this comment

balakrishna-deriv Jan 6, 2022

Choose a reason for hiding this comment

balakrishna-deriv Jan 6, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Feb 25, 2022

vercel bot commented Oct 7, 2021 •

edited

Loading

github-actions bot commented Oct 7, 2021 •

edited

Loading