arash/default to volatility indices on weekends #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarAhl
reviewed
May 14, 2019
|
@OskarAhl |
OskarAhl
reviewed
May 15, 2019
OskarAhl
previously approved these changes
May 15, 2019
easteregg
previously requested changes
May 30, 2019
src/javascript/app/Stores/Modules/Trading/Helpers/__tests__/active-symbols.js
Outdated
Show resolved
Hide resolved
src/javascript/app/Stores/Modules/Trading/Helpers/__tests__/active-symbols.js
Outdated
Show resolved
Hide resolved
src/javascript/app/Stores/Modules/Trading/Helpers/active-symbols.js
Outdated
Show resolved
Hide resolved
src/javascript/app/Stores/Modules/Trading/Helpers/active-symbols.js
Outdated
Show resolved
Hide resolved
src/javascript/app/Stores/Modules/Trading/Helpers/__tests__/active-symbols.js
Outdated
Show resolved
Hide resolved
|
There are conflicts which should be addressed. |
negarn
approved these changes
Jun 12, 2019
yauheni-deriv
referenced
this pull request
in yauheni-deriv/deriv-app
Oct 26, 2022
…mailtemplate_ts_migration yauheni/76930/sendemailtemplate ts migration
sanjam-deriv
pushed a commit
to sanjam-deriv/deriv-app
that referenced
this pull request
Nov 28, 2022
…ration_constants.js Suisin/refactor: ts migration for constants.js
yashim-deriv
pushed a commit
to yashim-deriv/deriv-app
that referenced
this pull request
Dec 15, 2022
…3/addrealaccount thisyahlen/ chore: add options account if no real account
yaswanth-deriv
referenced
this pull request
in yaswanth-deriv/deriv-app
Jan 25, 2023
…t-ts-migration Niloofar/ DropdownList component ts migration
rostislav-deriv
pushed a commit
to rostislav-deriv/deriv-app
that referenced
this pull request
Mar 16, 2023
* chore: migrate statement to tsx * fix: use Statement props from api-types than declaring it in ts file * fix: imported TAccountStatistics inside statement * fix: made changes based on comments * fix: refactor based on suggestions
hirad-deriv
added a commit
that referenced
this pull request
May 17, 2023
* refactor: initial commit * revert: revert changes * chore: ts-migration for positions-card.tsx (#5) * chore: reports-table-row to tsx (#10) * chore: migrating error-components to tsx (#8) * chore: migrating error-components to tsx * fix: added partial to type * chore: migrate calendar-icon to tsx (#11) * chore: migrate calendar-icon to tsx * fix: updated extensions * chore: migrate list-item to tsx (#12) * chore: migrate currency-wrapper to ts (#17) * chore: migrate empty-portfolio-message to ts (#18) * chore: migrating reports meta to tsx (#23) * chore: migrate amount-cell to ts (#16) * chore: migrate amount-cell to ts * fix: delete component because it is unused * chore: migrating EmptyTradeHistoryMessage to tsx (#19) * chore: migrating EmptyTradeHistoryMessage to tsx * fix: remove extension * fix: migrated sidelist to tsx (#13) * fix: migrated sidelist to tsx * fix: circle-ci error * fix: sidelist types * chore: migrate composite calendar mobile to typescript (#26) * chore: migrate composite calendar mobile to typescript * fix: remove component extension from the name * refactor: ♻️ removed unused component (#30) * chore: migrate index file to typescript (#27) * refactor: ♻️ migrate component to tsx (#29) * chore: two-month-picker to tsx with one calendar component (#15) * chore: migrate account statistics to ts (#14) * chore: migrate account statistics to ts * fix: typo in comment * Akmal / chore: migrate routes config to typescript (#31) * chore: migrate routes config to typescript * fix: change type for component * Akmal / chore: migrate data-table-constants to typescript (#33) * chore: migrate data-table-constants to typescript * fix: refactor types * chore: migrate loading component to typescript (#36) * Aizad/73988/msir ts (#21) * chore: migrate market-symbol-icon-row to ts * fix: remove commented lines * fix: remove classname from IconTradeTypes * fix: removed action prop * Sergei / chore: migrate open-positions to tsx (#40) * chore: convert open-positions to tsx * fix: add React.PropsWithChildren to tabs.tsx * fix: change Tabs type * fix: add/change some types and fix some undefined values * refactor: use Return Early pattern for contract-card-sell component * chore: delete commented lines * chore: add moment as dev dependency * chore: commit to check circleCI * fix: change back tabs.tsx * fix: change React.Fragment to null * Akmal / chore: convert helpers to typescript (#28) * chore: convert elpers to typescript * fix: types * chore: migrate placeholder to tsx (#42) * chore: migate placeholder to tsx * fix: destructure props and remove React.propswithchildre * Sergei / 73980 / chore: ts migration of route-with-sub-routes (#45) * chore: ts migration of route-with-sub-routes * refactor: add common types to separate files * fix: get back composite-calendar * refactor: change path from absolute to relative for Types * Sergei / 73979 / chore: ts migration of binary-routes (#46) * chore: ts migration of binary-routes.jsx * chore: add TPassthrough type and add key as index when route.path is undefined * chore: add export for TBinaryRoutes type * refactor: use types from common types * Aizad/73977/binary link ts (#41) * chore: migrate routes folder to tsx * fix: change type for component * fix: migrated test cases to tsx * chore: migrate binary-links to tsx * fix: change back function names * fix: resolved conflict issues * fix: testcases * chore: migrated filter component and fix some issues with composite-c… (#20) * chore: migrated filter component and fix some issues with composite-calendar * fix: change export to CalendarIcon on index.js and added RootStore type to filter-components * fix: change TRootStore to RootStore * fix: replace RootStore to TRootStore * fix: expand object for filtered_date_range * Sergei / chore: ts migration of routes (#38) * chore: ts migration of routes * chore: change RootStore type * Aizad/73994/pss ts (#48) * chore: migrate progress-slider-stream to tsx * fix: imported TContractInfo inside deriv/shared/ * Sergei / chore: migrate statements to tsx (#39) * chore: ts migration of statements * chore: change RootStore type * chore: change local TRootStore with module property * fix: return class RootStore to Stores/index.ts * chore: change core_store type * chore: migrated indicative cell to tsx (#44) * chore: migrated indicative cell to tsx * fix: added types to usestate * fix: change type * fix: change function type to boolean * fix: imported TContractInfo from shared file into indicative-cell * fix: test * fix: mockstore * fix: format-response.ts * fix: mockstore * Aizad/73978/routes ts (#50) * Merge branch 'Improvement/72232/Reports_TS_migration' of github.com:mahdiyeh-deriv/deriv-app into ts-migration * chore: finalising routes folder migration for Reports package 📦 * Akmal / chore: migrate app.jsx to typescript (#37) * chore: migrate app.jsx to typescript * chore: utilize TRootStore type * chore: replace type * Akmal / chore: migrate composite calendar to typescript (#25) * chore: migrate composite calendar to typescript * chore: refactor composite calendar and related components to properly use moment * chore: move out index changes * feat: resolve conflicts * feat: add deriv stores package * Kate/73995/TS migration of Reports (#51) * refactor: migrate reports component into ts * refactor: add useStore hook * refactor: delete extra react fragment Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * redeploy: rerun tests * refactor: remove named import from react * chore: migrate statement to tsx (#47) * chore: migrate statement to tsx * fix: use Statement props from api-types than declaring it in ts file * fix: imported TAccountStatistics inside statement * fix: made changes based on comments * fix: refactor based on suggestions * fix: types in packages/shared/src/utils/shortcode/shortcode.ts * fix: regex to prevent sonarcloud bug * chore: change index.js to index.ts * Rostislav / 73993 / Task - TS migration of ProfitTable (#34) * refactor: init pr * refactor: profit_loss_cell tsx'd * refactor: profit_loss_cell import problem resolved * refactor: profit_loss_cell import another problem fix * refactor: the migration is more or less finished * refactor: a few extra changes * refactor: prev commit accidental changes removed * refactor: TProfitTable type changed a bit * refactor: moved types to common-prop.type.ts * refactor: getSupportedContracts and getUnsupportedContracts moved to shared * refactor: contract.tsx completely replaced by imports from @deriv/shared * refactor: added alias for Types * refactor: applied suggested changes * fix: regex for sonarcloud * fix: remove props from the name of type declaration * fix: resolve comments * fix: fix comments v2 * fix: remove usestate * fix: date-time test * fix: comments v3 * thisyahlen/fix: trade table for mobile (#52) * fix: trade table for mobile * fix: trade table error * fix: statement input validation error on date_from * fix: setdate unix * fix: responsive input validation error * fix: remove unix from store --------- Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev>
nijil-deriv
pushed a commit
to nijil-deriv/deriv-app
that referenced
this pull request
May 24, 2023
* refactor: initial commit * revert: revert changes * chore: ts-migration for positions-card.tsx (deriv-com#5) * chore: reports-table-row to tsx (deriv-com#10) * chore: migrating error-components to tsx (deriv-com#8) * chore: migrating error-components to tsx * fix: added partial to type * chore: migrate calendar-icon to tsx (deriv-com#11) * chore: migrate calendar-icon to tsx * fix: updated extensions * chore: migrate list-item to tsx (deriv-com#12) * chore: migrate currency-wrapper to ts (deriv-com#17) * chore: migrate empty-portfolio-message to ts (deriv-com#18) * chore: migrating reports meta to tsx (deriv-com#23) * chore: migrate amount-cell to ts (deriv-com#16) * chore: migrate amount-cell to ts * fix: delete component because it is unused * chore: migrating EmptyTradeHistoryMessage to tsx (deriv-com#19) * chore: migrating EmptyTradeHistoryMessage to tsx * fix: remove extension * fix: migrated sidelist to tsx (deriv-com#13) * fix: migrated sidelist to tsx * fix: circle-ci error * fix: sidelist types * chore: migrate composite calendar mobile to typescript (deriv-com#26) * chore: migrate composite calendar mobile to typescript * fix: remove component extension from the name * refactor: ♻️ removed unused component (deriv-com#30) * chore: migrate index file to typescript (deriv-com#27) * refactor: ♻️ migrate component to tsx (deriv-com#29) * chore: two-month-picker to tsx with one calendar component (deriv-com#15) * chore: migrate account statistics to ts (deriv-com#14) * chore: migrate account statistics to ts * fix: typo in comment * Akmal / chore: migrate routes config to typescript (deriv-com#31) * chore: migrate routes config to typescript * fix: change type for component * Akmal / chore: migrate data-table-constants to typescript (deriv-com#33) * chore: migrate data-table-constants to typescript * fix: refactor types * chore: migrate loading component to typescript (deriv-com#36) * Aizad/73988/msir ts (deriv-com#21) * chore: migrate market-symbol-icon-row to ts * fix: remove commented lines * fix: remove classname from IconTradeTypes * fix: removed action prop * Sergei / chore: migrate open-positions to tsx (deriv-com#40) * chore: convert open-positions to tsx * fix: add React.PropsWithChildren to tabs.tsx * fix: change Tabs type * fix: add/change some types and fix some undefined values * refactor: use Return Early pattern for contract-card-sell component * chore: delete commented lines * chore: add moment as dev dependency * chore: commit to check circleCI * fix: change back tabs.tsx * fix: change React.Fragment to null * Akmal / chore: convert helpers to typescript (deriv-com#28) * chore: convert elpers to typescript * fix: types * chore: migrate placeholder to tsx (deriv-com#42) * chore: migate placeholder to tsx * fix: destructure props and remove React.propswithchildre * Sergei / 73980 / chore: ts migration of route-with-sub-routes (deriv-com#45) * chore: ts migration of route-with-sub-routes * refactor: add common types to separate files * fix: get back composite-calendar * refactor: change path from absolute to relative for Types * Sergei / 73979 / chore: ts migration of binary-routes (deriv-com#46) * chore: ts migration of binary-routes.jsx * chore: add TPassthrough type and add key as index when route.path is undefined * chore: add export for TBinaryRoutes type * refactor: use types from common types * Aizad/73977/binary link ts (deriv-com#41) * chore: migrate routes folder to tsx * fix: change type for component * fix: migrated test cases to tsx * chore: migrate binary-links to tsx * fix: change back function names * fix: resolved conflict issues * fix: testcases * chore: migrated filter component and fix some issues with composite-c… (deriv-com#20) * chore: migrated filter component and fix some issues with composite-calendar * fix: change export to CalendarIcon on index.js and added RootStore type to filter-components * fix: change TRootStore to RootStore * fix: replace RootStore to TRootStore * fix: expand object for filtered_date_range * Sergei / chore: ts migration of routes (deriv-com#38) * chore: ts migration of routes * chore: change RootStore type * Aizad/73994/pss ts (deriv-com#48) * chore: migrate progress-slider-stream to tsx * fix: imported TContractInfo inside deriv/shared/ * Sergei / chore: migrate statements to tsx (deriv-com#39) * chore: ts migration of statements * chore: change RootStore type * chore: change local TRootStore with module property * fix: return class RootStore to Stores/index.ts * chore: change core_store type * chore: migrated indicative cell to tsx (deriv-com#44) * chore: migrated indicative cell to tsx * fix: added types to usestate * fix: change type * fix: change function type to boolean * fix: imported TContractInfo from shared file into indicative-cell * fix: test * fix: mockstore * fix: format-response.ts * fix: mockstore * Aizad/73978/routes ts (deriv-com#50) * Merge branch 'Improvement/72232/Reports_TS_migration' of github.com:mahdiyeh-deriv/deriv-app into ts-migration * chore: finalising routes folder migration for Reports package 📦 * Akmal / chore: migrate app.jsx to typescript (deriv-com#37) * chore: migrate app.jsx to typescript * chore: utilize TRootStore type * chore: replace type * Akmal / chore: migrate composite calendar to typescript (deriv-com#25) * chore: migrate composite calendar to typescript * chore: refactor composite calendar and related components to properly use moment * chore: move out index changes * feat: resolve conflicts * feat: add deriv stores package * Kate/73995/TS migration of Reports (deriv-com#51) * refactor: migrate reports component into ts * refactor: add useStore hook * refactor: delete extra react fragment Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * redeploy: rerun tests * refactor: remove named import from react * chore: migrate statement to tsx (deriv-com#47) * chore: migrate statement to tsx * fix: use Statement props from api-types than declaring it in ts file * fix: imported TAccountStatistics inside statement * fix: made changes based on comments * fix: refactor based on suggestions * fix: types in packages/shared/src/utils/shortcode/shortcode.ts * fix: regex to prevent sonarcloud bug * chore: change index.js to index.ts * Rostislav / 73993 / Task - TS migration of ProfitTable (deriv-com#34) * refactor: init pr * refactor: profit_loss_cell tsx'd * refactor: profit_loss_cell import problem resolved * refactor: profit_loss_cell import another problem fix * refactor: the migration is more or less finished * refactor: a few extra changes * refactor: prev commit accidental changes removed * refactor: TProfitTable type changed a bit * refactor: moved types to common-prop.type.ts * refactor: getSupportedContracts and getUnsupportedContracts moved to shared * refactor: contract.tsx completely replaced by imports from @deriv/shared * refactor: added alias for Types * refactor: applied suggested changes * fix: regex for sonarcloud * fix: remove props from the name of type declaration * fix: resolve comments * fix: fix comments v2 * fix: remove usestate * fix: date-time test * fix: comments v3 * thisyahlen/fix: trade table for mobile (deriv-com#52) * fix: trade table for mobile * fix: trade table error * fix: statement input validation error on date_from * fix: setdate unix * fix: responsive input validation error * fix: remove unix from store --------- Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev>
shaheer-deriv
referenced
this pull request
in shaheer-deriv/deriv-app
Jun 22, 2023
Diel : Fixing codesmells, TS errors and onboarding close issue
shontzu-deriv
pushed a commit
to shontzu-deriv/deriv-app
that referenced
this pull request
Jul 4, 2023
…re-account-implementation feat: demo account compare implemetation tweaks as per design
farhan-nurzi-deriv
pushed a commit
to farhan-nurzi-deriv/deriv-app
that referenced
this pull request
Jul 21, 2023
…change Shaheer/diel flow change
farhan-nurzi-deriv
pushed a commit
to farhan-nurzi-deriv/deriv-app
that referenced
this pull request
Jul 21, 2023
…re_branch Merge pull request deriv-com#47 from shaheer-deriv/shaheer/DIEL_flow_change
farhan-nurzi-deriv
pushed a commit
to farhan-nurzi-deriv/deriv-app
that referenced
this pull request
Aug 18, 2023
…yment-method-modal refactor: add payment method modal
ali-hosseini-deriv
pushed a commit
that referenced
this pull request
Sep 22, 2023
* refactor: ♻️ initial commit * refactor: 🎨 fixed import file paths * fix: 🧑💻 incorporate sonarcloud review * refactor: ♻️ migrated reset-trading-password component to TSX * refactor: 🎨 resolved build failure * fix: ♻️ incorporated lint errors * fix: 🎨 incorporated review comments * fix: 🐛 resize issue * refactor: 🎨 migrated account component to TSX (#47) * refactor: 🎨 migrated account component to TSX * fix: 🎨 refactored code * refactor: 🎨 migrated account to tsx * fix: 🎨 incorporated review comments * chore: 💚 trigger empty commit * fix: 🧪 failing testcase * fix: 🐛 resolve password modal API failure * fix: 🐛 bug regd disabled Financial Assessment * fix: 🚚 updated paths * Merge branch 'master' into sprint-9/account-package-refactor
vinu-deriv
pushed a commit
that referenced
this pull request
Oct 10, 2023
* refactor: ♻️ initial commit * refactor: 🎨 fixed import file paths * fix: 🧑💻 incorporate sonarcloud review * refactor: ♻️ migrated reset-trading-password component to TSX * refactor: 🎨 resolved build failure * fix: ♻️ incorporated lint errors * fix: 🎨 incorporated review comments * fix: 🐛 resize issue * refactor: 🎨 migrated account component to TSX (#47) * refactor: 🎨 migrated account component to TSX * fix: 🎨 refactored code * refactor: 🎨 migrated account to tsx * fix: 🎨 incorporated review comments * chore: 💚 trigger empty commit * fix: 🧪 failing testcase * fix: 🐛 resolve password modal API failure * fix: 🐛 bug regd disabled Financial Assessment * fix: 🚚 updated paths * Merge branch 'master' into sprint-9/account-package-refactor
vinu-deriv
pushed a commit
that referenced
this pull request
Oct 10, 2023
* refactor: ♻️ initial commit * refactor: 🎨 fixed import file paths * fix: 🧑💻 incorporate sonarcloud review * refactor: ♻️ migrated reset-trading-password component to TSX * refactor: 🎨 resolved build failure * fix: ♻️ incorporated lint errors * fix: 🎨 incorporated review comments * fix: 🐛 resize issue * refactor: 🎨 migrated account component to TSX (#47) * refactor: 🎨 migrated account component to TSX * fix: 🎨 refactored code * refactor: 🎨 migrated account to tsx * fix: 🎨 incorporated review comments * chore: 💚 trigger empty commit * fix: 🧪 failing testcase * fix: 🐛 resolve password modal API failure * fix: 🐛 bug regd disabled Financial Assessment * fix: 🚚 updated paths * Merge branch 'master' into sprint-9/account-package-refactor
henry-deriv
pushed a commit
to henry-deriv/deriv-app
that referenced
this pull request
May 29, 2024
…tails chore: useOrderDetails hook with order details
Dhruv-deriv
pushed a commit
to Dhruv-deriv/deriv-app
that referenced
this pull request
Jun 9, 2024
…-conflicts-and-update-branch Revert "Fasih/ Updated with parent branch and resolved conflicts"
utkarsha-deriv
pushed a commit
to utkarsha-deriv/deriv-app
that referenced
this pull request
Jul 30, 2024
…conflicts-passkey-notification Utkarsha/resolve conflicts passkey notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.