Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

george / added FA error code check, redirection link to FA #4775

Conversation

george-usynin-deriv
Copy link
Contributor

@george-usynin-deriv george-usynin-deriv commented Jan 27, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Jan 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/8SAb2uAPv5ShLXAVZeYNY3pTr7Sr
✅ Preview: https://deriv-app-git-fork-george-usynin-deriv-20323fa-redirectl-823ea2.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/4775](https://github.com/binary-com/deriv-app/pull/4775)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-george-usynin-deriv-20323fa-redirectl-823ea2.binary.sx?qa_server=frontend.binaryws.com&app_id=23814
    - **Original**: https://deriv-app-git-fork-george-usynin-deriv-20323fa-redirectl-823ea2.binary.sx
- **App ID**: `23814`

title: localize('Cashier Error'),
cancel_button_text: undefined,
confirm_button_text: localize('OK'),
onConfirm: undefined,
Copy link
Contributor

@farrah-deriv farrah-deriv Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is undefined, clicking on OK button will not redirect to financial assessment. Is this expected?

Copy link
Contributor Author

@george-usynin-deriv george-usynin-deriv Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farrah-deriv when the client wants to reach FA page, he clicks on "financial assessment" text-link which highlighted by red color. If the client wants to continue working with transfers, he clicks OK, and remains on the same page. Therefore, this behaviour is expected.

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants