Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likhith/greying out payment method when ad is disabled #4991

Merged

Conversation

likhith-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Added a CSS style to override the text color of the payment method when the the ad is disabled

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Mar 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/HLeevugGpcZk4VF5oig7QJvG6YxY
✅ Preview: https://deriv-app-git-fork-likhith-deriv-design-diffgreyout-inactive-pm.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/4991](https://github.com/binary-com/deriv-app/pull/4991)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-design-diffgreyout-inactive-pm.binary.sx?qa_server=frontend.binaryws.com&app_id=24166
    - **Original**: https://deriv-app-git-fork-likhith-deriv-design-diffgreyout-inactive-pm.binary.sx
- **App ID**: `24166`

@codecov-commenter
Copy link

Codecov Report

Merging #4991 (7a2d038) into master (5e007d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4991   +/-   ##
=======================================
  Coverage   13.52%   13.52%           
=======================================
  Files        1247     1247           
  Lines       28393    28393           
  Branches     4837     4837           
=======================================
  Hits         3839     3839           
  Misses      24319    24319           
  Partials      235      235           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e007d6...7a2d038. Read the comment docs.

@vercel
Copy link

vercel bot commented Apr 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 5:07AM (UTC)

@carolsachdeva carolsachdeva merged commit 5750bfb into deriv-com:master Apr 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
* Fixed: Greying PM when ad is disabled

* Removed restricting condition

Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants