Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yashim/chore: bumped postcss/babel related packages. fixed bootstrap warnings #5122

Merged

Conversation

yashim-deriv
Copy link
Contributor

@yashim-deriv yashim-deriv commented Mar 29, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • Upgraded postcss/babel dependencies to the latest
  • Added babel config to silence build warnings
  • Add babel regex plugin to @deriv/core to fix build errors

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Mar 29, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/2tXoMqkVWSkdBBRwaF723PQbYAUe
✅ Preview: https://deriv-app-git-fork-yashim-deriv-fixdeprecatedlibrariesconfigs.binary.sx

matin-deriv
matin-deriv previously approved these changes Mar 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5122](https://github.com/binary-com/deriv-app/pull/5122)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yashim-deriv-fixdeprecatedlibrariesconfigs.binary.sx?qa_server=frontend.binaryws.com&app_id=24061
    - **Original**: https://deriv-app-git-fork-yashim-deriv-fixdeprecatedlibrariesconfigs.binary.sx
- **App ID**: `24061`

@yashim-deriv yashim-deriv changed the title chore: bumped postcss/babel related packages. fixed bootstrap warnings yashim/chore: bumped postcss/babel related packages. fixed bootstrap warnings Mar 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@699dc4a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5122   +/-   ##
=========================================
  Coverage          ?   12.13%           
=========================================
  Files             ?     1247           
  Lines             ?    28373           
  Branches          ?     4827           
=========================================
  Hits              ?     3443           
  Misses            ?    24700           
  Partials          ?      230           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699dc4a...e4553bf. Read the comment docs.

@balakrishna-deriv
Copy link
Contributor

LGTM 👌

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants