Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mahdiyeh/Fix: empty positions on mobile #5275

Merged

Conversation

mahdiyeh-deriv
Copy link
Contributor

@mahdiyeh-deriv mahdiyeh-deriv commented Apr 18, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • Fix empty position message to become visible on mobile.

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 4:20AM (UTC)

@codecov-commenter
Copy link

Codecov Report

Merging #5275 (8c4a7fd) into master (daf3591) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5275      +/-   ##
==========================================
- Coverage   13.33%   13.33%   -0.01%     
==========================================
  Files        1282     1282              
  Lines       29017    29019       +2     
  Branches     4893     4894       +1     
==========================================
  Hits         3870     3870              
- Misses      24909    24911       +2     
  Partials      238      238              
Impacted Files Coverage Δ
...der/src/App/Containers/trade-header-extensions.jsx 0.00% <0.00%> (ø)
...les/Reports/Components/empty-portfolio-message.jsx 33.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf3591...8c4a7fd. Read the comment docs.

Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5275](https://github.com/binary-com/deriv-app/pull/5275)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mahdiyeh-fs-fixemptypositionsonmobile.binary.sx?qa_server=frontend.binaryws.com&app_id=24099
    - **Original**: https://deriv-app-git-fork-mahdiyeh-fs-fixemptypositionsonmobile.binary.sx
- **App ID**: `24099`

@carolsachdeva carolsachdeva merged commit 219f868 into deriv-com:master Apr 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
* Chore: Change no open position message

* Chore: Add paddings

* show empty position message on mobile

Co-authored-by: Matin-binary <matin@deriv.com>
Co-authored-by: Yashim Wong <75345074+yashim-deriv@users.noreply.github.com>
Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants