Mahdiyeh/ Fix: rerendering the TradingPasswordModal component #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mahdiyeh-deriv
commented
Apr 20, 2022
| @@ -206,7 +206,7 @@ const ResetTradingPasswordModal = ({ | |||
| const [dialog_title, setDialogTitle] = React.useState(''); | |||
| const history = useHistory(); | |||
| React.useEffect(() => { | |||
| if (is_visible) { | |||
| if (is_visible && history.location.search !== '') { | |||
There was a problem hiding this comment.
replacing the history resulted in rerendering the component , adding the condition prevent the unnecessary re-rendering
matin-deriv
previously approved these changes
Apr 20, 2022
mahdiyeh-deriv
force-pushed
the
hotfix_trading_password
branch
from
b6f419e
to
e603d04
Compare
Codecov Report
@@ Coverage Diff @@
## master #5286 +/- ##
==========================================
- Coverage 13.33% 13.33% -0.01%
==========================================
Files 1282 1282
Lines 29019 29020 +1
Branches 4894 4895 +1
==========================================
Hits 3870 3870
- Misses 24911 24912 +1
Partials 238 238
Continue to review full report at Codecov.
|
matin-deriv
approved these changes
Apr 21, 2022
matin-deriv
approved these changes
Apr 21, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
sandeep-deriv
pushed a commit
to sandeep-deriv/deriv-app
that referenced
this pull request
Apr 29, 2022
…com#5286) * fix rerendering the TradingPasswordModal component * fix reopening the invester password Co-authored-by: Matin shafiei <matin@deriv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change