Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carol/ P2P: Fix ads paused modal visibility #5301

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

carolsachdeva
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Fix ads paused modal is only visible when visibility status from BE shows it should.

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 4:29AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5301](https://github.com/binary-com/deriv-app/pull/5301)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-carol-binary-paused-modal.binary.sx?qa_server=frontend.binaryws.com&app_id=23847
    - **Original**: https://deriv-app-git-fork-carol-binary-paused-modal.binary.sx
- **App ID**: `23847`

@codecov-commenter
Copy link

Codecov Report

Merging #5301 (655396a) into master (3310ac0) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #5301   +/-   ##
=======================================
  Coverage   13.33%   13.33%           
=======================================
  Files        1282     1282           
  Lines       29020    29020           
  Branches     4895     4895           
=======================================
  Hits         3870     3870           
  Misses      24912    24912           
  Partials      238      238           
Impacted Files Coverage Δ
...kages/p2p/src/components/my-ads/create-ad-form.jsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3310ac0...655396a. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.6% 12.6% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants