Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ameerul /Bug #65052 Inconsistent scrolling behaviour #5505

Merged
merged 23 commits into from
Aug 29, 2022

Conversation

ameerul-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Added styling changes for when the user scrolls on the P2P page on the mobile view.
  • Fixed overflow as some tabs showed 2 scroll bars.

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • [ x] Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented May 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 7:57AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5505](https://github.com/binary-com/deriv-app/pull/5505)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-tabs-scrolling-issue.binary.sx?qa_server=frontend.binaryws.com&app_id=31227
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-tabs-scrolling-issue.binary.sx
- **App ID**: `31227`

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #5505 (b08009a) into master (7af898d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #5505   +/-   ##
=======================================
  Coverage   21.28%   21.28%           
=======================================
  Files        1385     1385           
  Lines       31471    31471           
  Branches     5360     5360           
=======================================
  Hits         6700     6700           
  Misses      24393    24393           
  Partials      378      378           
Impacted Files Coverage Δ
...ackages/cashier/src/containers/cashier/cashier.jsx 97.22% <ø> (ø)
...kages/p2p/src/components/my-profile/my-profile.jsx 0.00% <ø> (ø)
...thods/add-payment-method/select-payment-method.jsx 0.00% <0.00%> (ø)
...ds/payment-methods-empty/payment-methods-empty.jsx 0.00% <ø> (ø)
...hods/payment-methods-list/payment-methods-list.jsx 0.00% <ø> (ø)
...components/order-details/order-details-wrapper.jsx 87.50% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

farrah-deriv
farrah-deriv previously approved these changes May 23, 2022
likhith-deriv
likhith-deriv previously approved these changes May 24, 2022
carolsachdeva
carolsachdeva previously approved these changes May 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

adrienne-deriv
adrienne-deriv previously approved these changes Jun 22, 2022
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

farrah-deriv
farrah-deriv previously approved these changes Jun 22, 2022
farrah-deriv
farrah-deriv previously approved these changes Aug 2, 2022
nijil-deriv
nijil-deriv previously approved these changes Aug 2, 2022
adrienne-deriv
adrienne-deriv previously approved these changes Aug 4, 2022
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nijil-deriv
nijil-deriv previously approved these changes Aug 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

@farrah-deriv farrah-deriv merged commit 2c46006 into deriv-com:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants