Farzin/72980/Migrate cashier to mobx-react-lite
#6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
farzin-deriv
commented
Aug 11, 2022
| @@ -15,7 +14,7 @@ const Routes = ({ error, has_error, is_logged_in, is_logging_in, passthrough }) | |||
| }; | |||
|
|
|||
| Routes.propTypes = { | |||
| error: MobxPropTypes.objectOrObservableObject, | |||
| error: PropTypes.any, | |||
There was a problem hiding this comment.
Should replace with the proper type.
farzin-deriv
commented
Aug 11, 2022
| @@ -90,7 +89,7 @@ PaymentAgentDeposit.propTypes = { | |||
| onChangePaymentMethod: PropTypes.func, | |||
| payment_agent_list: PropTypes.array, | |||
| selected_bank: PropTypes.oneOfType([PropTypes.number, PropTypes.string]), | |||
| supported_banks: MobxPropTypes.arrayOrObservableArray, | |||
| supported_banks: PropTypes.any, | |||
There was a problem hiding this comment.
Should replace with the proper type.
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Codecov Report
@@ Coverage Diff @@
## master #6161 +/- ##
==========================================
- Coverage 20.71% 20.71% -0.01%
==========================================
Files 1403 1403
Lines 32102 32104 +2
Branches 5432 5434 +2
==========================================
Hits 6649 6649
- Misses 25042 25044 +2
Partials 411 411
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hamid-deriv
previously approved these changes
Aug 14, 2022
vinu-deriv
previously approved these changes
Aug 16, 2022
heorhi-deriv
previously approved these changes
Aug 16, 2022
farzin-deriv
dismissed stale reviews from vinu-deriv and hamid-deriv
via
8d08985
farzin-deriv
requested review from
balakrishna-deriv and
matin-deriv
as code owners
farzin-deriv
force-pushed
the
farzin/72980/migrate_to_mobx_react_lite
branch
from
3fd286d
to
e21c513
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
mobx-reactwithmobx-react-liteWhen you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change