Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likhith/fix warnings and errors on app startup #6179

Conversation

likhith-deriv
Copy link
Contributor

@likhith-deriv likhith-deriv commented Aug 11, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • Resolved the issues that led to warnings and console errors on Deriv app start up
  • Removed empty files that were present due to code refactor

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 11:11AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6179](https://github.com/binary-com/deriv-app/pull/6179)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-fix-wraningsanderrorsonstartup.binary.sx?qa_server=frontend.binaryws.com&app_id=32112
    - **Original**: https://deriv-app-git-fork-likhith-deriv-fix-wraningsanderrorsonstartup.binary.sx
- **App ID**: `32112`

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #6179 (3ef2d26) into master (16a93bf) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #6179   +/-   ##
=======================================
  Coverage   21.76%   21.76%           
=======================================
  Files        1386     1386           
  Lines       31487    31487           
  Branches     5362     5362           
=======================================
  Hits         6854     6854           
  Misses      24240    24240           
  Partials      393      393           
Impacted Files Coverage Δ
...mponents/composite-checkbox/composite-checkbox.jsx 0.00% <ø> (ø)
...omponents/src/components/dropdown/display-text.jsx 0.00% <ø> (ø)
...es/components/src/components/dropdown/dropdown.jsx 0.00% <0.00%> (ø)
packages/shared/src/utils/date/date-time.js 77.94% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

matin-deriv
matin-deriv previously approved these changes Aug 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants