Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bala/revert mobx6 #6364

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

balakrishna-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@balakrishna-deriv balakrishna-deriv marked this pull request as ready for review September 2, 2022 03:41
@vercel
Copy link

vercel bot commented Sep 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 4:00AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6364](https://github.com/binary-com/deriv-app/pull/6364)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-balakrishna-binary-revert-mobx-6.binary.sx?qa_server=frontend.binaryws.com&app_id=24078
    - **Original**: https://deriv-app-git-fork-balakrishna-binary-revert-mobx-6.binary.sx
- **App ID**: `24078`

@codecov-commenter
Copy link

Codecov Report

Merging #6364 (dd467c3) into master (1b672e8) will increase coverage by 0.53%.
The diff coverage is 42.73%.

❗ Current head dd467c3 differs from pull request most recent head 02c9961. Consider uploading reports for the commit 02c9961 to get more accurate results

@@            Coverage Diff             @@
##           master    #6364      +/-   ##
==========================================
+ Coverage   20.72%   21.25%   +0.53%     
==========================================
  Files        1402     1401       -1     
  Lines       32076    32018      -58     
  Branches     5420     5419       -1     
==========================================
+ Hits         6648     6806     +158     
+ Misses      25017    24801     -216     
  Partials      411      411              
Impacted Files Coverage Δ
packages/cfd/src/Stores/Modules/CFD/cfd-store.js 0.00% <0.00%> (ø)
packages/cfd/src/Stores/base-store.js 0.51% <0.00%> (+<0.01%) ⬆️
packages/core/src/Stores/active-symbols-store.js 0.00% <0.00%> (-33.34%) ⬇️
packages/core/src/Stores/chart-barrier-store.js 59.09% <ø> (-1.78%) ⬇️
packages/core/src/Stores/contract-store.js 0.00% <0.00%> (ø)
packages/core/src/Stores/contract-trade-store.js 6.49% <0.00%> (-7.61%) ⬇️
packages/core/src/Stores/gtm-store.js 5.08% <ø> (-1.59%) ⬇️
packages/core/src/Stores/menu-store.js 0.00% <0.00%> (-30.00%) ⬇️
packages/core/src/Stores/notification-store.js 1.84% <0.00%> (-2.94%) ⬇️
packages/core/src/Stores/pushwoosh-store.js 18.18% <ø> (-12.26%) ⬇️
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

@carolsachdeva carolsachdeva merged commit 02d4362 into deriv-com:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants