-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mahdiyeh/Cfd store implementation #6676
Merged
mahdiyeh-deriv
merged 2 commits into
deriv-com:pre-appstore
from
mahdiyeh-deriv:CFDStore_implementation
Oct 4, 2022
Merged
Mahdiyeh/Cfd store implementation #6676
mahdiyeh-deriv
merged 2 commits into
deriv-com:pre-appstore
from
mahdiyeh-deriv:CFDStore_implementation
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahdiyeh-deriv
requested review from
matin-deriv,
balakrishna-deriv,
yashim-deriv and
nijil-deriv
as code owners
October 4, 2022 11:43
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mahdiyeh-deriv
commented
Oct 4, 2022
@@ -12,7 +12,6 @@ import PortfolioStore from './portfolio-store'; | |||
import ContractReplayStore from './contract-replay-store'; | |||
import ContractTradeStore from './contract-trade-store'; | |||
import { ChartBarrierStore } from './chart-barrier-store'; | |||
import CFDAccountStore from './cfd-account-store'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have access to CFDStore we do not need this store any more
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
hirad-deriv
approved these changes
Oct 4, 2022
…FDStore_implementation
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change