Mahdiyeh/73628/compare account modal #6721

mahdiyeh-deriv · 2022-10-09T09:38:01Z

Changes:

Please include a summary of the change and which issue is fixed below:

...

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2022-10-09T09:38:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
deriv-app	✅ Ready (Inspect)	Visit Preview	Oct 11, 2022 at 5:51AM (UTC)

github-actions · 2022-10-09T10:12:47Z

A production App ID was automatically generated for this PR. (log)

PR: Mahdiyeh/73628/compare account modal #6721
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-mahdiyeh-fs-mahdiyeh-73628compareacco-f25d52.binary.sx?qa_server=frontend.binaryws.com&app_id=24061
- Original: https://deriv-app-git-fork-mahdiyeh-fs-mahdiyeh-73628compareacco-f25d52.binary.sx
App ID: 24061

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/6721](https://github.com/binary-com/deriv-app/pull/6721)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mahdiyeh-fs-mahdiyeh-73628compareacco-f25d52.binary.sx?qa_server=frontend.binaryws.com&app_id=24061
    - **Original**: https://deriv-app-git-fork-mahdiyeh-fs-mahdiyeh-73628compareacco-f25d52.binary.sx
- **App ID**: `24061`

codecov-commenter · 2022-10-09T10:25:58Z

Codecov Report

❗ No coverage uploaded for pull request base (pre-appstore@fff7e6d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             pre-appstore    #6721   +/-   ##
===============================================
  Coverage                ?   21.29%           
===============================================
  Files                   ?     1532           
  Lines                   ?    34037           
  Branches                ?     5951           
===============================================
  Hits                    ?     7248           
  Misses                  ?    26309           
  Partials                ?      480

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…ahdiyeh/73628/CompareAccountModal

matin-deriv · 2022-10-11T03:41:40Z

packages/cfd/src/Containers/mt5-compare-table-content.tsx

@@ -123,6 +125,7 @@ const content: TModalContentProps[] = [
                    'Choosing this jurisdiction will give you a Financial STP account. Your trades will go directly to the market and have tighter spreads.'
                ),
            },
+            derivx: { text: localize('St. Vincent & Grenadines') },


Why do we need Deriv X related info here?
Is this part of the requirements?

for the modal that we should show to the trading-hub we need to show mt5 and derivx details together.

matin-deriv

pls address the failed builds.

mahdiyeh-deriv · 2022-10-11T04:26:52Z

packages/cfd/src/Containers/mt5-compare-table-content.tsx

@@ -314,7 +314,7 @@ const DMT5CompareModalContent = ({
                    'financial_bvi',
                    'financial_vanuatu',
                    'financial_labuan',
-                    ...(should_show_derivx ? ['derivx'] : []),
+                    ...(should_show_derivx && synthetic_accounts_count > 0 ? ['derivx'] : []),


when we have mt5 synthetic accounts we should show derivx

sonarcloud · 2022-10-11T05:46:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

mahdiyeh-deriv added 2 commits October 9, 2022 12:55

initial changes

8ca784c

add compare accounts modal

5e836b6

boring-cyborg bot added AppStore Components labels Oct 9, 2022

fix account switcher

86dbc11

vercel bot had a problem deploying to Preview October 9, 2022 09:55 Failure

use relative path

88b91b4

mahdiyeh-deriv marked this pull request as ready for review October 9, 2022 10:07

mahdiyeh-deriv requested review from matin-deriv, balakrishna-deriv and yashim-deriv as code owners October 9, 2022 10:07

vercel bot deployed to Preview October 9, 2022 10:12 View deployment

Merge branch 'pre-appstore' of github.com:binary-com/deriv-app into m…

66517df

…ahdiyeh/73628/CompareAccountModal

vercel bot had a problem deploying to Preview October 10, 2022 10:37 Failure

hirad-deriv approved these changes Oct 10, 2022

View reviewed changes

matin-deriv reviewed Oct 11, 2022

View reviewed changes

fix aliases in cfd

a886205

vercel bot deployed to Preview October 11, 2022 04:17 View deployment

not to show derivx in table when we do not have synthetic accounts

e9438b5

mahdiyeh-deriv commented Oct 11, 2022

View reviewed changes

vercel bot deployed to Preview October 11, 2022 04:37 View deployment

matin-deriv approved these changes Oct 11, 2022

View reviewed changes

fix table when there is no synthetic account

15702ac

vercel bot deployed to Preview October 11, 2022 05:51 View deployment

matin-deriv approved these changes Oct 11, 2022

View reviewed changes

mahdiyeh-deriv merged commit 350813f into deriv-com:pre-appstore Oct 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mahdiyeh/73628/compare account modal #6721

Mahdiyeh/73628/compare account modal #6721

mahdiyeh-deriv commented Oct 9, 2022

vercel bot commented Oct 9, 2022 •

edited

Loading

github-actions bot commented Oct 9, 2022 •

edited

Loading

codecov-commenter commented Oct 9, 2022 •

edited

Loading

matin-deriv Oct 11, 2022

mahdiyeh-deriv Oct 11, 2022

matin-deriv left a comment

mahdiyeh-deriv Oct 11, 2022

sonarcloud bot commented Oct 11, 2022

Mahdiyeh/73628/compare account modal #6721

Mahdiyeh/73628/compare account modal #6721

Conversation

mahdiyeh-deriv commented Oct 9, 2022

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Oct 9, 2022 • edited Loading

github-actions bot commented Oct 9, 2022 • edited Loading

codecov-commenter commented Oct 9, 2022 • edited Loading

Codecov Report

matin-deriv Oct 11, 2022

Choose a reason for hiding this comment

mahdiyeh-deriv Oct 11, 2022

Choose a reason for hiding this comment

matin-deriv left a comment

Choose a reason for hiding this comment

mahdiyeh-deriv Oct 11, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Oct 11, 2022

vercel bot commented Oct 9, 2022 •

edited

Loading

github-actions bot commented Oct 9, 2022 •

edited

Loading

codecov-commenter commented Oct 9, 2022 •

edited

Loading